Re: [PATCH 1/1] fix(rootfs): close progress reporter after last step finished

[Zhihang Wei <wzh@ilbers.de>]

Applied to next, thanks.

Zhihang

On 6/29/26 17:04, 'Felix Moessbauer' via isar-users wrote:
> We currently stop the progress reporter after each step. This is
> incorrect, as finish must only be called after the last step. However,
> the impact is quite limited. Currently the only observable effect is
> that - when running in debug mode - a summary of all previous execution
> times is printed per step (instead of once).
>
> We further want to call finish also if a step raises, hence we move it
> to the finally block.
>
> Fixes: eae54341 ("rootfs: Add missing umounts in rootfs ...")
> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> ---
>   meta/classes-recipe/rootfs.bbclass | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes-recipe/rootfs.bbclass b/meta/classes-recipe/rootfs.bbclass
> index a58ad031..8e45c10d 100644
> --- a/meta/classes-recipe/rootfs.bbclass
> +++ b/meta/classes-recipe/rootfs.bbclass
> @@ -458,8 +458,8 @@ python do_rootfs_install() {
>   
>               if "release-after" in (d.getVarFlag(cmd, 'isar-apt-lock') or ""):
>                   bb.utils.unlockfile(lock)
> -            progress_reporter.finish()
>       finally:
> +        progress_reporter.finish()
>           bb.build.exec_func('rootfs_do_umounts', d)
>   }
>   addtask rootfs_install before do_rootfs_postprocess after do_unpack

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/69e6840c-b0b9-4b3a-bbb9-b3e98b1a800e%40ilbers.de.