[PATCH v2 0/3] Various improvements of the Isar testsuite

[PATCH v2 0/3] Various improvements of the Isar testsuite

['Felix Moessbauer' via isar-users]

Changes since v1:

- drop previous p3 (nocross -> alltargets), this will be reworked
  in a dedicated series
- move qemumipsel-bullseye to dedicated test that is skipped in rootless mode
  (the @skipUnless decorator cannot be used as it has no access to the params)
- build all test that are not explicitly marked as non-cross under cross

Felix Moessbauer (3):
  testsuite: compress sdk with zstd to speedup dev test
  testsuite: disable qemumipsel-bullseye tests in rootless mode
  testsuite: only build no-cross test class without cross

 testsuite/citest.py | 27 +++++++++++++++++++++++----
 1 file changed, 23 insertions(+), 4 deletions(-)

-- 
2.55.0

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/20260810090125.654670-1-felix.moessbauer%40siemens.com.

[PATCH v2 1/3] testsuite: compress sdk with zstd to speedup dev test

['Felix Moessbauer' via isar-users]

We only change it in the dev test, as this test is expected to finish as
quickly as possible. By that, we get even better test coverage, as other
tests still use xz compression.

Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
---
 testsuite/citest.py | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/testsuite/citest.py b/testsuite/citest.py
index fcd08c95..a41b77c8 100644
--- a/testsuite/citest.py
+++ b/testsuite/citest.py
@@ -73,7 +73,11 @@ class DevTest(CIBaseTest):
         ]
 
         self.init()
-        self.perform_build_test(targets, image_install='example-raw')
+        self.perform_build_test(
+            targets,
+            image_install='example-raw',
+            lines=['SDK_FORMATS = "tar.zst"'],
+        )
 
     def test_dev_run_arm_bookworm(self):
         self.init()
-- 
2.55.0

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/20260810090125.654670-2-felix.moessbauer%40siemens.com.

[PATCH v2 2/3] testsuite: disable qemumipsel-bullseye tests in rootless mode

['Felix Moessbauer' via isar-users]

The pam + adduser combination of qemumipsel on bullseye does not work in
unprivileged user namespaces. By that, no users can be added to the
image. This results in the following error during do_rootfs_install:

 chfn: PAM: System error
 adduser: `/bin/chfn -f systemd Network Management systemd-network' returned error code 1. Exiting.
 dpkg: error processing package systemd (--configure):
  installed systemd package post-installation script subprocess returned error exit status 1

As this target and distro combination is exotic, we just remove it from
the testsuite if running in rootless mode.

Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
---
 testsuite/citest.py | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

diff --git a/testsuite/citest.py b/testsuite/citest.py
index a41b77c8..2841dbdc 100644
--- a/testsuite/citest.py
+++ b/testsuite/citest.py
@@ -928,7 +928,6 @@ class NoCrossTest(CIBaseTest):
             'mc:qemui386-bullseye:isar-image-base',
             'mc:qemuamd64-buster:isar-image-ci',
             'mc:qemuamd64-bullseye:isar-initramfs',
-            'mc:qemumipsel-bullseye:isar-image-base',
             'mc:phyboard-mira-bullseye:isar-image-base',
             'mc:hikey-bullseye:isar-image-base',
             'mc:virtualbox-bullseye:isar-image-base',
@@ -962,6 +961,19 @@ class NoCrossTest(CIBaseTest):
         self.init()
         self.perform_build_test(targets, cross=False)
 
+    def test_nocross_mipsel_bullseye(self):
+        """
+        On bullseye mipsel, the pam + adduser combination does not
+        work in unprivileged namespaces.
+        """
+        if bool(int(self.params.get('rootless', default=0))):
+            self.cancel('mipsel bullseye not supported in rootless mode')
+
+        self.init()
+        self.perform_build_test(
+            ['mc:qemumipsel-bullseye:isar-image-base'],
+            cross=False)
+
     def test_run_arm_bullseye(self):
         """
         :avocado: tags=startvm
@@ -1120,6 +1132,9 @@ class NoCrossTest(CIBaseTest):
         """
         :avocado: tags=startvm
         """
+        if bool(int(self.params.get('rootless', default=0))):
+            self.cancel('mipsel bullseye not supported in rootless mode')
+
         self.init()
         self.vm_start('mipsel', 'bullseye')
 
-- 
2.55.0

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/20260810090125.654670-3-felix.moessbauer%40siemens.com.

Re: [PATCH v2 2/3] testsuite: disable qemumipsel-bullseye tests in rootless mode

[Zhihang Wei]

On 8/10/26 11:01, Felix Moessbauer wrote:
> The pam + adduser combination of qemumipsel on bullseye does not work in
> unprivileged user namespaces. By that, no users can be added to the
> image. This results in the following error during do_rootfs_install:
>
>   chfn: PAM: System error
>   adduser: `/bin/chfn -f systemd Network Management systemd-network' returned error code 1. Exiting.
>   dpkg: error processing package systemd (--configure):
>    installed systemd package post-installation script subprocess returned error exit status 1
>
> As this target and distro combination is exotic, we just remove it from
> the testsuite if running in rootless mode.
>
> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> ---
>   testsuite/citest.py | 17 ++++++++++++++++-
>   1 file changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/testsuite/citest.py b/testsuite/citest.py
> index a41b77c8..2841dbdc 100644
> --- a/testsuite/citest.py
> +++ b/testsuite/citest.py
> @@ -928,7 +928,6 @@ class NoCrossTest(CIBaseTest):
>               'mc:qemui386-bullseye:isar-image-base',
>               'mc:qemuamd64-buster:isar-image-ci',
>               'mc:qemuamd64-bullseye:isar-initramfs',
> -            'mc:qemumipsel-bullseye:isar-image-base',
>               'mc:phyboard-mira-bullseye:isar-image-base',
>               'mc:hikey-bullseye:isar-image-base',
>               'mc:virtualbox-bullseye:isar-image-base',
> @@ -962,6 +961,19 @@ class NoCrossTest(CIBaseTest):
>           self.init()
>           self.perform_build_test(targets, cross=False)
>   
> +    def test_nocross_mipsel_bullseye(self):
> +        """
> +        On bullseye mipsel, the pam + adduser combination does not
> +        work in unprivileged namespaces.
> +        """
> +        if bool(int(self.params.get('rootless', default=0))):
> +            self.cancel('mipsel bullseye not supported in rootless mode')
> +
> +        self.init()
> +        self.perform_build_test(
> +            ['mc:qemumipsel-bullseye:isar-image-base'],
> +            cross=False)
> +
>       def test_run_arm_bullseye(self):

Hi,
Now the startvm tests need to follow right after their builds :) Putting
test_nocross_mipsel_bullseye here makes the startvm tests right after it
fail.

Zhihang

>           """
>           :avocado: tags=startvm
> @@ -1120,6 +1132,9 @@ class NoCrossTest(CIBaseTest):
>           """
>           :avocado: tags=startvm
>           """
> +        if bool(int(self.params.get('rootless', default=0))):
> +            self.cancel('mipsel bullseye not supported in rootless mode')
> +
>           self.init()
>           self.vm_start('mipsel', 'bullseye')
>   

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/310cc54f-6e04-4cfa-bc74-565a2ad437e6%40ilbers.de.

Re: [PATCH v2 2/3] testsuite: disable qemumipsel-bullseye tests in rootless mode

['MOESSBAUER, Felix' via isar-users]

On Wed, 2026-08-12 at 16:03 +0200, Zhihang Wei wrote:
> On 8/10/26 11:01, Felix Moessbauer wrote:
> > The pam + adduser combination of qemumipsel on bullseye does not work in
> > unprivileged user namespaces. By that, no users can be added to the
> > image. This results in the following error during do_rootfs_install:
> > 
> >   chfn: PAM: System error
> >   adduser: `/bin/chfn -f systemd Network Management systemd-network' returned error code 1. Exiting.
> >   dpkg: error processing package systemd (--configure):
> >    installed systemd package post-installation script subprocess returned error exit status 1
> > 
> > As this target and distro combination is exotic, we just remove it from
> > the testsuite if running in rootless mode.
> > 
> > Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> > ---
> >   testsuite/citest.py | 17 ++++++++++++++++-
> >   1 file changed, 16 insertions(+), 1 deletion(-)
> > 
> > diff --git a/testsuite/citest.py b/testsuite/citest.py
> > index a41b77c8..2841dbdc 100644
> > --- a/testsuite/citest.py
> > +++ b/testsuite/citest.py
> > @@ -928,7 +928,6 @@ class NoCrossTest(CIBaseTest):
> >               'mc:qemui386-bullseye:isar-image-base',
> >               'mc:qemuamd64-buster:isar-image-ci',
> >               'mc:qemuamd64-bullseye:isar-initramfs',
> > -            'mc:qemumipsel-bullseye:isar-image-base',
> >               'mc:phyboard-mira-bullseye:isar-image-base',
> >               'mc:hikey-bullseye:isar-image-base',
> >               'mc:virtualbox-bullseye:isar-image-base',
> > @@ -962,6 +961,19 @@ class NoCrossTest(CIBaseTest):
> >           self.init()
> >           self.perform_build_test(targets, cross=False)
> >   
> > +    def test_nocross_mipsel_bullseye(self):
> > +        """
> > +        On bullseye mipsel, the pam + adduser combination does not
> > +        work in unprivileged namespaces.
> > +        """
> > +        if bool(int(self.params.get('rootless', default=0))):
> > +            self.cancel('mipsel bullseye not supported in rootless mode')
> > +
> > +        self.init()
> > +        self.perform_build_test(
> > +            ['mc:qemumipsel-bullseye:isar-image-base'],
> > +            cross=False)
> > +
> >       def test_run_arm_bullseye(self):
> 
> Hi,
> Now the startvm tests need to follow right after their builds :) Putting
> test_nocross_mipsel_bullseye here makes the startvm tests right after it
> fail.

Hi, again the hidden dependencies. I will send a v3 to fix it.

BUT... Can we please get rid of the hidden inter-test dependencies by
simply moving the startvm tests into the build tests? This has bitten
us too many times (or move to pytest which can model inter-test
dependencies).

Felix

> 
> Zhihang
> 
> >           """
> >           :avocado: tags=startvm
> > @@ -1120,6 +1132,9 @@ class NoCrossTest(CIBaseTest):
> >           """
> >           :avocado: tags=startvm
> >           """
> > +        if bool(int(self.params.get('rootless', default=0))):
> > +            self.cancel('mipsel bullseye not supported in rootless mode')
> > +
> >           self.init()
> >           self.vm_start('mipsel', 'bullseye')
> >   

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/4c1f92c8d3bf53f477d9a0992940d4903b038b23.camel%40siemens.com.

[PATCH v2 3/3] testsuite: only build no-cross test class without cross

['Felix Moessbauer' via isar-users]

The cross support in isar is mature and used for quite some time. As a
preparation to build more targets under cross, we remove the disabling
of cross building for all test jobs that are not explicitly marked as
non-cross.

Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
---
 testsuite/citest.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/testsuite/citest.py b/testsuite/citest.py
index 2841dbdc..fb58421e 100644
--- a/testsuite/citest.py
+++ b/testsuite/citest.py
@@ -202,7 +202,7 @@ class ReproTest(CIBaseTest):
 
         self.init()
         try:
-            self.perform_repro_test(targets, cross=False)
+            self.perform_repro_test(targets)
         finally:
             self.move_in_build_dir('tmp', 'tmp_repro_unsigned')
 
@@ -437,7 +437,7 @@ class CrossTest(CIBaseTest):
         ]
 
         self.init()
-        self.perform_build_test(targets, cross=False)
+        self.perform_build_test(targets)
 
     def test_cross_kselftest(self):
         targets = [
-- 
2.55.0

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/20260810090125.654670-4-felix.moessbauer%40siemens.com.