public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
* [PATCH 1/1] rootfs: unconditionally clean isar-apt lists before deploying
@ 2026-09-23 15:42 'Felix Moessbauer' via isar-users
  2026-09-29  8:08 ` Zhihang Wei
  0 siblings, 1 reply; 2+ messages in thread
From: 'Felix Moessbauer' via isar-users @ 2026-09-23 15:42 UTC (permalink / raw)
  To: isar-users; +Cc: Felix Moessbauer

The isar-apt data is non-deterministic across builds, as the content of
the isar-apt itself changes whenever new packages are added or removed.
By that, it makes the whole chroot non-reproducible which results in
cache trashing when not building the exactly same set of targets.

As the isar-apt is anyways updated prior to using it (both in sbuild, as
well as in the rootfs tasks), we can safely drop it from the rootfs.

Note, that we cannot do the same for the upstream apt lists, as they
must not change during the build. But as they are never updated and also
do not depend on the bitbake state, it is safe to keep them.

Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
---
 meta/classes-recipe/rootfs.bbclass | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/meta/classes-recipe/rootfs.bbclass b/meta/classes-recipe/rootfs.bbclass
index d033bdf0..1fa733d9 100644
--- a/meta/classes-recipe/rootfs.bbclass
+++ b/meta/classes-recipe/rootfs.bbclass
@@ -559,6 +559,12 @@ rootfs_postprocess_clean_package_cache() {
         \( -name '*.deb' -o -name '*.bin' \) -delete
 }
 
+# always clean the isar-apt as it is not reproducible and anyways unconditionally updated
+ROOTFS_POSTPROCESS_COMMAND += "rootfs_postprocess_clean_isar_apt_lists"
+rootfs_postprocess_clean_isar_apt_lists() {
+    run_privileged find "${ROOTFSDIR}/var/lib/apt/lists" -type f -name '_isar-apt*' -delete
+}
+
 ROOTFS_POSTPROCESS_COMMAND += "${@bb.utils.contains('ROOTFS_FEATURES', 'clean-apt-lists', 'rootfs_postprocess_clean_apt_lists', '', d)}"
 rootfs_postprocess_clean_apt_lists() {
     run_privileged find "${ROOTFSDIR}/var/lib/apt/lists" -type f -delete
-- 
2.55.0

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/20260923154243.2429624-1-felix.moessbauer%40siemens.com.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/1] rootfs: unconditionally clean isar-apt lists before deploying
  2026-09-23 15:42 [PATCH 1/1] rootfs: unconditionally clean isar-apt lists before deploying 'Felix Moessbauer' via isar-users
@ 2026-09-29  8:08 ` Zhihang Wei
  0 siblings, 0 replies; 2+ messages in thread
From: Zhihang Wei @ 2026-09-29  8:08 UTC (permalink / raw)
  To: Felix Moessbauer, isar-users

Applied to next, thanks.

Zhihang

On 9/23/26 17:42, 'Felix Moessbauer' via isar-users wrote:
> The isar-apt data is non-deterministic across builds, as the content of
> the isar-apt itself changes whenever new packages are added or removed.
> By that, it makes the whole chroot non-reproducible which results in
> cache trashing when not building the exactly same set of targets.
>
> As the isar-apt is anyways updated prior to using it (both in sbuild, as
> well as in the rootfs tasks), we can safely drop it from the rootfs.
>
> Note, that we cannot do the same for the upstream apt lists, as they
> must not change during the build. But as they are never updated and also
> do not depend on the bitbake state, it is safe to keep them.
>
> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> ---
>   meta/classes-recipe/rootfs.bbclass | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/meta/classes-recipe/rootfs.bbclass b/meta/classes-recipe/rootfs.bbclass
> index d033bdf0..1fa733d9 100644
> --- a/meta/classes-recipe/rootfs.bbclass
> +++ b/meta/classes-recipe/rootfs.bbclass
> @@ -559,6 +559,12 @@ rootfs_postprocess_clean_package_cache() {
>           \( -name '*.deb' -o -name '*.bin' \) -delete
>   }
>   
> +# always clean the isar-apt as it is not reproducible and anyways unconditionally updated
> +ROOTFS_POSTPROCESS_COMMAND += "rootfs_postprocess_clean_isar_apt_lists"
> +rootfs_postprocess_clean_isar_apt_lists() {
> +    run_privileged find "${ROOTFSDIR}/var/lib/apt/lists" -type f -name '_isar-apt*' -delete
> +}
> +
>   ROOTFS_POSTPROCESS_COMMAND += "${@bb.utils.contains('ROOTFS_FEATURES', 'clean-apt-lists', 'rootfs_postprocess_clean_apt_lists', '', d)}"
>   rootfs_postprocess_clean_apt_lists() {
>       run_privileged find "${ROOTFSDIR}/var/lib/apt/lists" -type f -delete

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/aa5ab46a-26f6-43ed-af94-e0e9496f0732%40ilbers.de.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-09-29  8:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-23 15:42 [PATCH 1/1] rootfs: unconditionally clean isar-apt lists before deploying 'Felix Moessbauer' via isar-users
2026-09-29  8:08 ` Zhihang Wei

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox