public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
* [PATCH] deb-dl-dir: Remove unnecessary mounts cleanup call
@ 2026-05-22 14:52 Anton Mikanovich
  2026-06-01 13:16 ` Zhihang Wei
  0 siblings, 1 reply; 2+ messages in thread
From: Anton Mikanovich @ 2026-05-22 14:52 UTC (permalink / raw)
  To: isar-users; +Cc: Anton Mikanovich, Amaia Gomez

After removing of 'debsrc_undo_mounts' function there is no need in
calling it during cleanup.

Fixes: 9ad502bb ("deb-dl-dir: optimize caching of source packages using apt natively").

Reported-by: Amaia Gomez <agomez@ulmapackaging.com>
Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
---
 meta/classes-recipe/deb-dl-dir.bbclass | 1 -
 1 file changed, 1 deletion(-)

diff --git a/meta/classes-recipe/deb-dl-dir.bbclass b/meta/classes-recipe/deb-dl-dir.bbclass
index 27d1fb24..620ddc96 100644
--- a/meta/classes-recipe/deb-dl-dir.bbclass
+++ b/meta/classes-recipe/deb-dl-dir.bbclass
@@ -50,7 +50,6 @@ debsrc_download() {
 
     if [ $(cat ${avail} | wc -l) -eq 0 ]; then
         bberror "No packages were found in apt cache"
-        debsrc_undo_mounts "${rootfs}"
         return 1
     fi
 
-- 
2.34.1

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/20260522145215.2857251-1-amikan%40ilbers.de.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] deb-dl-dir: Remove unnecessary mounts cleanup call
  2026-05-22 14:52 [PATCH] deb-dl-dir: Remove unnecessary mounts cleanup call Anton Mikanovich
@ 2026-06-01 13:16 ` Zhihang Wei
  0 siblings, 0 replies; 2+ messages in thread
From: Zhihang Wei @ 2026-06-01 13:16 UTC (permalink / raw)
  To: Anton Mikanovich, isar-users; +Cc: Amaia Gomez

Applied to next, thanks.

Zhihang

On 5/22/26 16:52, Anton Mikanovich wrote:
> After removing of 'debsrc_undo_mounts' function there is no need in
> calling it during cleanup.
>
> Fixes: 9ad502bb ("deb-dl-dir: optimize caching of source packages using apt natively").
>
> Reported-by: Amaia Gomez <agomez@ulmapackaging.com>
> Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
> ---
>   meta/classes-recipe/deb-dl-dir.bbclass | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/meta/classes-recipe/deb-dl-dir.bbclass b/meta/classes-recipe/deb-dl-dir.bbclass
> index 27d1fb24..620ddc96 100644
> --- a/meta/classes-recipe/deb-dl-dir.bbclass
> +++ b/meta/classes-recipe/deb-dl-dir.bbclass
> @@ -50,7 +50,6 @@ debsrc_download() {
>   
>       if [ $(cat ${avail} | wc -l) -eq 0 ]; then
>           bberror "No packages were found in apt cache"
> -        debsrc_undo_mounts "${rootfs}"
>           return 1
>       fi
>   

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/59039a32-6187-4fad-a32f-ee131b507543%40ilbers.de.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-06-01 13:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-05-22 14:52 [PATCH] deb-dl-dir: Remove unnecessary mounts cleanup call Anton Mikanovich
2026-06-01 13:16 ` Zhihang Wei

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox