public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Zhihang Wei <wzh@ilbers.de>
To: "MOESSBAUER, Felix" <felix.moessbauer@siemens.com>,
	"isar-users@googlegroups.com" <isar-users@googlegroups.com>
Cc: "Kiszka, Jan" <jan.kiszka@siemens.com>
Subject: Re: [PATCH v7 3/3] meta: Deploy image build artifacts into distro- and image-specific subdirs
Date: Fri, 10 Apr 2026 12:46:08 +0200	[thread overview]
Message-ID: <5f422d05-08ac-4447-b643-5043282d2ec3@ilbers.de> (raw)
In-Reply-To: <c576aebcf2cefe7db948970178cd1e515c072011.camel@siemens.com>



On 4/10/26 11:44, MOESSBAUER, Felix wrote:
> On Thu, 2026-02-26 at 17:26 +0100, Zhihang Wei wrote:
>> From: Ilia Skochilov <iskochilov@ilbers.de>
>>
>> When building different distros or images for the same machine (e.g.
>> phyboard-mira-bullseye and phyboard-mira-bookworm, or isar-image-ci
>> and isar-image-base), artifacts with identical names (e.g. DTB files)
>> may be deployed to the same location, resulting file conflicts and
>> build failures.
>>
>> Deploy image build artifacts into a subdirectory named
>> ${DISTRO}-${IMAGE_PN} to avoid such collisions.
>>
>> Since the directory now encodes the distro and image name, remove the
>> ${DISTRO} and ${IMAGE_PN} prefixes from artifact filenames to
>> keep the names short and clear.
>>
> [shortening a bit]
>
>> +IMAGE_PN ?= ""
>> +DEPLOY_DIR_IMAGE = "${DEPLOY_DIR}/images/${MACHINE}${@('/%s-%s' % (d.getVar('DISTRO'), d.getVar('IMAGE_PN'))) if d.getVar('IMAGE_PN') != '' else ''}"
> This cannot work, as the value of IMAGE_PN is late-expanded, hence
> different in the initrd recipe and the image recipe. The
> DEPLOY_DIR_IMAGE variable must only use data that is machine specific,
> not image specific (distro might be fine, though as this is identical
> for both initrd and image).
Understand the merge_wic_sbom problem here.

"merge_wic_sbom" cares only about the customized initrd, right? Then we
could probably change image artifacts (kernel, image, default initrd)
deploy path only in the image.bbclass, and not touching
DEPLOY_DIR_IMAGE.
> Voting for a revert of this patchset.
>
> PS: Regarding the DTB issue? Can't we simply prefix the DTBs with the
> IMAGE_PN? In do_copy_boot_files we know the IMAGE_PN and during wic-
> imaging we can remove the prefix again.
Prefixing DTBs with IMAGE_PN only may not be enough. We have two test 
cases: - Same machine, different distros, same image - Same machine, 
same distro, different images Both failed before this patch.
Zhihang

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/5f422d05-08ac-4447-b643-5043282d2ec3%40ilbers.de.

  parent reply	other threads:[~2026-04-10 10:46 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-26 16:26 Deploy DTBs and other image artifacts into subdirs to avoid conflicts Zhihang Wei
2026-02-26 16:26 ` [PATCH v7 1/3] wic: Obtain real machine name in isoimage source plugin Zhihang Wei
2026-02-26 16:26 ` [PATCH v7 2/3] testsuite: Add testcases to check dtb deployment Zhihang Wei
2026-02-26 16:26 ` [PATCH v7 3/3] meta: Deploy image build artifacts into distro- and image-specific subdirs Zhihang Wei
2026-03-02  9:45   ` 'Jan Kiszka' via isar-users
2026-03-03 10:22     ` Zhihang Wei
2026-03-03 12:50       ` 'Jan Kiszka' via isar-users
2026-03-03 13:35         ` Zhihang Wei
2026-03-24 14:36           ` Zhihang Wei
2026-03-24 14:48             ` 'Jan Kiszka' via isar-users
2026-03-25 16:41               ` Baurzhan Ismagulov
2026-03-26  6:03                 ` 'Jan Kiszka' via isar-users
2026-03-26 15:56                   ` Baurzhan Ismagulov
2026-03-27  6:33                     ` 'Jan Kiszka' via isar-users
2026-04-10  9:44   ` 'MOESSBAUER, Felix' via isar-users
2026-04-10 10:35     ` 'Jan Kiszka' via isar-users
2026-04-10 10:46     ` Zhihang Wei [this message]
2026-04-10 11:39       ` 'MOESSBAUER, Felix' via isar-users

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5f422d05-08ac-4447-b643-5043282d2ec3@ilbers.de \
    --to=wzh@ilbers.de \
    --cc=felix.moessbauer@siemens.com \
    --cc=isar-users@googlegroups.com \
    --cc=jan.kiszka@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox