Re: [PATCH v7 3/3] meta: Deploy image build artifacts into distro- and image-specific subdirs

["'Jan Kiszka' via isar-users" <isar-users@googlegroups.com>]

On 10.04.26 11:44, Moessbauer, Felix (FT RPD CED OES-DE) wrote:
> On Thu, 2026-02-26 at 17:26 +0100, Zhihang Wei wrote:
>> From: Ilia Skochilov <iskochilov@ilbers.de>
>>
>> When building different distros or images for the same machine (e.g.
>> phyboard-mira-bullseye and phyboard-mira-bookworm, or isar-image-ci
>> and isar-image-base), artifacts with identical names (e.g. DTB files)
>> may be deployed to the same location, resulting file conflicts and
>> build failures.
>>
>> Deploy image build artifacts into a subdirectory named
>> ${DISTRO}-${IMAGE_PN} to avoid such collisions.
>>
>> Since the directory now encodes the distro and image name, remove the
>> ${DISTRO} and ${IMAGE_PN} prefixes from artifact filenames to
>> keep the names short and clear.
>>
> 
> [shortening a bit]
> 
>>
>> +IMAGE_PN ?= ""
>> +DEPLOY_DIR_IMAGE = "${DEPLOY_DIR}/images/${MACHINE}${@('/%s-%s' % (d.getVar('DISTRO'), d.getVar('IMAGE_PN'))) if d.getVar('IMAGE_PN') != '' else ''}"
> 
> This cannot work, as the value of IMAGE_PN is late-expanded, hence
> different in the initrd recipe and the image recipe. The
> DEPLOY_DIR_IMAGE variable must only use data that is machine specific,
> not image specific (distro might be fine, though as this is identical
> for both initrd and image).
> 
> Voting for a revert of this patchset.
> 
> PS: Regarding the DTB issue? Can't we simply prefix the DTBs with the
> IMAGE_PN? In do_copy_boot_files we know the IMAGE_PN and during wic-
> imaging we can remove the prefix again.

I would rather vote for exploring the OE suggestion of having separate
TMPDIRs for problematic multiconfig builds first. Moving DTBs around
will also cause quite some adjustment efforts because they are consumed
from the deploy dir in various recipes, some also only downstream.

Jan

-- 
Siemens AG, Foundational Technologies
Linux Expert Center

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/dd09393c-3987-44c2-86d8-32facc860006%40siemens.com.