public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
* [PATCH v4] image-postproc: ignore systemd preset failures
@ 2026-04-27  4:21 'Badrikesh Prusty' via isar-users
  2026-04-27  9:59 ` 'Jan Kiszka' via isar-users
  0 siblings, 1 reply; 3+ messages in thread
From: 'Badrikesh Prusty' via isar-users @ 2026-04-27  4:21 UTC (permalink / raw)
  To: isar-users
  Cc: felix.moessbauer, jan.kiszka, gokhan.cetin, alexander.heinisch,
	Badrikesh Prusty

Add '|| true' to systemd preset invocation during image postprocessing
to tolerate failures caused by already-masked units.

Fixes: 72b88a12 ("classes/image-postproc: Enable systemd units based on systemd presets")

Signed-off-by: Badrikesh Prusty <badrikesh.prusty@siemens.com>
---
 meta/classes-recipe/rootfs.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes-recipe/rootfs.bbclass b/meta/classes-recipe/rootfs.bbclass
index 8b502a50..adb6c614 100644
--- a/meta/classes-recipe/rootfs.bbclass
+++ b/meta/classes-recipe/rootfs.bbclass
@@ -574,7 +574,7 @@ image_postprocess_populate_systemd_preset() {
         --show systemd || echo "" )

     if (test "$SYSTEMD_INSTALLED" = "installed"); then
-        sudo chroot '${ROOTFSDIR}' systemctl preset-all --preset-mode="enable-only"
+        sudo chroot '${ROOTFSDIR}' systemctl preset-all --preset-mode="enable-only" || true
     fi
 }

--
2.47.3

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/20260427042148.945434-1-badrikesh.prusty%40siemens.com.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v4] image-postproc: ignore systemd preset failures
  2026-04-27  4:21 [PATCH v4] image-postproc: ignore systemd preset failures 'Badrikesh Prusty' via isar-users
@ 2026-04-27  9:59 ` 'Jan Kiszka' via isar-users
  2026-04-29  6:47   ` 'Prusty, Badrikesh' via isar-users
  0 siblings, 1 reply; 3+ messages in thread
From: 'Jan Kiszka' via isar-users @ 2026-04-27  9:59 UTC (permalink / raw)
  To: Badrikesh Prusty, isar-users
  Cc: felix.moessbauer, gokhan.cetin, alexander.heinisch

On 27.04.26 06:21, Badrikesh Prusty wrote:
> Add '|| true' to systemd preset invocation during image postprocessing
> to tolerate failures caused by already-masked units.
> 
> Fixes: 72b88a12 ("classes/image-postproc: Enable systemd units based on systemd presets")
> 
> Signed-off-by: Badrikesh Prusty <badrikesh.prusty@siemens.com>
> ---
>  meta/classes-recipe/rootfs.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes-recipe/rootfs.bbclass b/meta/classes-recipe/rootfs.bbclass
> index 8b502a50..adb6c614 100644
> --- a/meta/classes-recipe/rootfs.bbclass
> +++ b/meta/classes-recipe/rootfs.bbclass
> @@ -574,7 +574,7 @@ image_postprocess_populate_systemd_preset() {
>          --show systemd || echo "" )
> 
>      if (test "$SYSTEMD_INSTALLED" = "installed"); then
> -        sudo chroot '${ROOTFSDIR}' systemctl preset-all --preset-mode="enable-only"
> +        sudo chroot '${ROOTFSDIR}' systemctl preset-all --preset-mode="enable-only" || true

A better pattern than "|| true" is

[ masked ] || systemctl ...

Jan

-- 
Siemens AG, Foundational Technologies
Linux Expert Center

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/d2ef88a6-3a31-48ee-93b0-e4885ae6f0e5%40siemens.com.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH v4] image-postproc: ignore systemd preset failures
  2026-04-27  9:59 ` 'Jan Kiszka' via isar-users
@ 2026-04-29  6:47   ` 'Prusty, Badrikesh' via isar-users
  0 siblings, 0 replies; 3+ messages in thread
From: 'Prusty, Badrikesh' via isar-users @ 2026-04-29  6:47 UTC (permalink / raw)
  To: Kiszka, Jan, isar-users
  Cc: MOESSBAUER, Felix, Cetin, Gokhan, Heinisch, Alexander

Hi,

Thanks for the suggestion. Updated as suggested. Link: https://groups.google.com/g/isar-users/c/wojTiSSPfG4


Many thanks,
Badrikesh


-----Original Message-----
From: Kiszka, Jan (FT RPD CED) <jan.kiszka@siemens.com> 
Sent: 27 April 2026 15:30
To: Prusty, Badrikesh (FT FDS CES LX PBU 2) <badrikesh.prusty@siemens.com>; isar-users@googlegroups.com
Cc: Moessbauer, Felix (FT RPD CED OES-DE) <felix.moessbauer@siemens.com>; Çetin, Gökhan (FT D EU TR C&E) <gokhan.cetin@siemens.com>; Heinisch, Alexander (FT RPD CED SES-AT) <alexander.heinisch@siemens.com>
Subject: Re: [PATCH v4] image-postproc: ignore systemd preset failures

On 27.04.26 06:21, Badrikesh Prusty wrote:
> Add '|| true' to systemd preset invocation during image postprocessing 
> to tolerate failures caused by already-masked units.
> 
> Fixes: 72b88a12 ("classes/image-postproc: Enable systemd units based 
> on systemd presets")
> 
> Signed-off-by: Badrikesh Prusty <badrikesh.prusty@siemens.com>
> ---
>  meta/classes-recipe/rootfs.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes-recipe/rootfs.bbclass 
> b/meta/classes-recipe/rootfs.bbclass
> index 8b502a50..adb6c614 100644
> --- a/meta/classes-recipe/rootfs.bbclass
> +++ b/meta/classes-recipe/rootfs.bbclass
> @@ -574,7 +574,7 @@ image_postprocess_populate_systemd_preset() {
>          --show systemd || echo "" )
> 
>      if (test "$SYSTEMD_INSTALLED" = "installed"); then
> -        sudo chroot '${ROOTFSDIR}' systemctl preset-all --preset-mode="enable-only"
> +        sudo chroot '${ROOTFSDIR}' systemctl preset-all 
> + --preset-mode="enable-only" || true

A better pattern than "|| true" is

[ masked ] || systemctl ...

Jan

--
Siemens AG, Foundational Technologies
Linux Expert Center

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/SG2PR06MB5107CC636CF781C80C03066B91342%40SG2PR06MB5107.apcprd06.prod.outlook.com.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-04-29  6:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-04-27  4:21 [PATCH v4] image-postproc: ignore systemd preset failures 'Badrikesh Prusty' via isar-users
2026-04-27  9:59 ` 'Jan Kiszka' via isar-users
2026-04-29  6:47   ` 'Prusty, Badrikesh' via isar-users

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox