* [PATCH] meta: Remove overrides from kernel filename selection @ 2026-05-28 13:56 Anton Mikanovich 2026-05-28 14:20 ` 'MOESSBAUER, Felix' via isar-users 2026-06-08 6:13 ` Anton Mikanovich 0 siblings, 2 replies; 10+ messages in thread From: Anton Mikanovich @ 2026-05-28 13:56 UTC (permalink / raw) To: isar-users; +Cc: Anton Mikanovich, Felix Moessbauer Because of the override processing logic values set by overrides can be changed only by overrides. It makes redifinition of KERNEL_FILE value made by simple assignment be ignored, which was already broken for the rpi-arm64-v8 machine. Rebuild selection logic to be done in bitbake.conf without overrides. Keep KERNEL_FILE redifinition for the rpi targets as an example of its usage for the downstreams. Signed-off-by: Anton Mikanovich <amikan@ilbers.de> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com> --- meta/classes-recipe/linux-kernel.bbclass | 3 --- meta/conf/bitbake.conf | 5 +---- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/meta/classes-recipe/linux-kernel.bbclass b/meta/classes-recipe/linux-kernel.bbclass index 55ea6d63..e4ae356d 100644 --- a/meta/classes-recipe/linux-kernel.bbclass +++ b/meta/classes-recipe/linux-kernel.bbclass @@ -211,9 +211,6 @@ def get_kernel_arch(d): KERNEL_ARCH ??= "${@get_kernel_arch(d)}" -# set KERNEL_FILE without depending on package arch used in bitbake.conf -KERNEL_FILE:forcevariable = "${@ 'vmlinux' if d.getVar('KERNEL_ARCH') in ['mipsel', 'riscv', 'arm64'] else 'vmlinuz'}" - KERNEL_CONFIG_FRAGMENTS ?= "" def config_fragments(d): diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf index 08c525d9..6db10eb3 100644 --- a/meta/conf/bitbake.conf +++ b/meta/conf/bitbake.conf @@ -65,10 +65,7 @@ SCHROOT_HOST_DIR = "${DEPLOY_DIR}/schroot-host/${HOST_DISTRO}-${HOST_ARCH}_${DIS SCHROOT_TARGET_DIR = "${DEPLOY_DIR}/schroot-target/${DISTRO}-${DISTRO_ARCH}" SDKCHROOT_DIR = "${DEPLOY_DIR_SDKCHROOT}/${BPN}-${DISTRO}-${MACHINE}" CACHE = "${TMPDIR}/cache" -KERNEL_FILE ?= "vmlinuz" -KERNEL_FILE:mipsel ?= "vmlinux" -KERNEL_FILE:riscv64 ?= "vmlinux" -KERNEL_FILE:arm64 ?= "vmlinux" +KERNEL_FILE ?= "${@ 'vmlinux' if d.getVar('DISTRO_ARCH') in ['mipsel', 'riscv64', 'arm64'] else 'vmlinuz'}" MACHINEOVERRIDES ?= "${MACHINE}" DISTROOVERRIDES ?= "${DISTRO}" -- 2.34.1 -- You received this message because you are subscribed to the Google Groups "isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/isar-users/20260528135624.3411792-1-amikan%40ilbers.de. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] meta: Remove overrides from kernel filename selection 2026-05-28 13:56 [PATCH] meta: Remove overrides from kernel filename selection Anton Mikanovich @ 2026-05-28 14:20 ` 'MOESSBAUER, Felix' via isar-users 2026-05-28 14:23 ` Anton Mikanovich 2026-06-08 6:26 ` 'Jan Kiszka' via isar-users 2026-06-08 6:13 ` Anton Mikanovich 1 sibling, 2 replies; 10+ messages in thread From: 'MOESSBAUER, Felix' via isar-users @ 2026-05-28 14:20 UTC (permalink / raw) To: amikan, isar-users On Thu, 2026-05-28 at 16:56 +0300, Anton Mikanovich wrote: > Because of the override processing logic values set by overrides can be > changed only by overrides. It makes redifinition of KERNEL_FILE value > made by simple assignment be ignored, which was already broken for the > rpi-arm64-v8 machine. > > Rebuild selection logic to be done in bitbake.conf without overrides. > Keep KERNEL_FILE redifinition for the rpi targets as an example of its > usage for the downstreams. > > Signed-off-by: Anton Mikanovich <amikan@ilbers.de> > Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com> > --- > meta/classes-recipe/linux-kernel.bbclass | 3 --- > meta/conf/bitbake.conf | 5 +---- > 2 files changed, 1 insertion(+), 7 deletions(-) > > diff --git a/meta/classes-recipe/linux-kernel.bbclass b/meta/classes-recipe/linux-kernel.bbclass > index 55ea6d63..e4ae356d 100644 > --- a/meta/classes-recipe/linux-kernel.bbclass > +++ b/meta/classes-recipe/linux-kernel.bbclass > @@ -211,9 +211,6 @@ def get_kernel_arch(d): > > KERNEL_ARCH ??= "${@get_kernel_arch(d)}" > > -# set KERNEL_FILE without depending on package arch used in bitbake.conf > -KERNEL_FILE:forcevariable = "${@ 'vmlinux' if d.getVar('KERNEL_ARCH') in ['mipsel', 'riscv', 'arm64'] else 'vmlinuz'}" Shall we remove the forcevariable override as well? At least in isar this was the last remaining user. > - > KERNEL_CONFIG_FRAGMENTS ?= "" > > def config_fragments(d): > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf > index 08c525d9..6db10eb3 100644 > --- a/meta/conf/bitbake.conf > +++ b/meta/conf/bitbake.conf > @@ -65,10 +65,7 @@ SCHROOT_HOST_DIR = "${DEPLOY_DIR}/schroot-host/${HOST_DISTRO}-${HOST_ARCH}_${DIS > SCHROOT_TARGET_DIR = "${DEPLOY_DIR}/schroot-target/${DISTRO}-${DISTRO_ARCH}" > SDKCHROOT_DIR = "${DEPLOY_DIR_SDKCHROOT}/${BPN}-${DISTRO}-${MACHINE}" > CACHE = "${TMPDIR}/cache" > -KERNEL_FILE ?= "vmlinuz" > -KERNEL_FILE:mipsel ?= "vmlinux" > -KERNEL_FILE:riscv64 ?= "vmlinux" > -KERNEL_FILE:arm64 ?= "vmlinux" > +KERNEL_FILE ?= "${@ 'vmlinux' if d.getVar('DISTRO_ARCH') in ['mipsel', 'riscv64', 'arm64'] else 'vmlinuz'}" Thanks, that's how I envisioned it. Felix > > MACHINEOVERRIDES ?= "${MACHINE}" > DISTROOVERRIDES ?= "${DISTRO}" > -- > 2.34.1 -- You received this message because you are subscribed to the Google Groups "isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/isar-users/33d2deaebb5eff75ea1d827016dd8f150b38c6f9.camel%40siemens.com. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] meta: Remove overrides from kernel filename selection 2026-05-28 14:20 ` 'MOESSBAUER, Felix' via isar-users @ 2026-05-28 14:23 ` Anton Mikanovich 2026-06-08 6:26 ` 'Jan Kiszka' via isar-users 1 sibling, 0 replies; 10+ messages in thread From: Anton Mikanovich @ 2026-05-28 14:23 UTC (permalink / raw) To: MOESSBAUER, Felix, isar-users 28.05.2026 17:20, MOESSBAUER, Felix wrote: > On Thu, 2026-05-28 at 16:56 +0300, Anton Mikanovich wrote: >> Because of the override processing logic values set by overrides can be >> changed only by overrides. It makes redifinition of KERNEL_FILE value >> made by simple assignment be ignored, which was already broken for the >> rpi-arm64-v8 machine. >> >> Rebuild selection logic to be done in bitbake.conf without overrides. >> Keep KERNEL_FILE redifinition for the rpi targets as an example of its >> usage for the downstreams. >> >> Signed-off-by: Anton Mikanovich <amikan@ilbers.de> >> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com> >> --- >> meta/classes-recipe/linux-kernel.bbclass | 3 --- >> meta/conf/bitbake.conf | 5 +---- >> 2 files changed, 1 insertion(+), 7 deletions(-) >> >> diff --git a/meta/classes-recipe/linux-kernel.bbclass b/meta/classes-recipe/linux-kernel.bbclass >> index 55ea6d63..e4ae356d 100644 >> --- a/meta/classes-recipe/linux-kernel.bbclass >> +++ b/meta/classes-recipe/linux-kernel.bbclass >> @@ -211,9 +211,6 @@ def get_kernel_arch(d): >> >> KERNEL_ARCH ??= "${@get_kernel_arch(d)}" >> >> -# set KERNEL_FILE without depending on package arch used in bitbake.conf >> -KERNEL_FILE:forcevariable = "${@ 'vmlinux' if d.getVar('KERNEL_ARCH') in ['mipsel', 'riscv', 'arm64'] else 'vmlinuz'}" > Shall we remove the forcevariable override as well? At least in isar > this was the last remaining user. It looks like something already existing when it's usage was added here. That's why I didn't delete the override itself. > >> - >> KERNEL_CONFIG_FRAGMENTS ?= "" >> >> def config_fragments(d): >> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf >> index 08c525d9..6db10eb3 100644 >> --- a/meta/conf/bitbake.conf >> +++ b/meta/conf/bitbake.conf >> @@ -65,10 +65,7 @@ SCHROOT_HOST_DIR = "${DEPLOY_DIR}/schroot-host/${HOST_DISTRO}-${HOST_ARCH}_${DIS >> SCHROOT_TARGET_DIR = "${DEPLOY_DIR}/schroot-target/${DISTRO}-${DISTRO_ARCH}" >> SDKCHROOT_DIR = "${DEPLOY_DIR_SDKCHROOT}/${BPN}-${DISTRO}-${MACHINE}" >> CACHE = "${TMPDIR}/cache" >> -KERNEL_FILE ?= "vmlinuz" >> -KERNEL_FILE:mipsel ?= "vmlinux" >> -KERNEL_FILE:riscv64 ?= "vmlinux" >> -KERNEL_FILE:arm64 ?= "vmlinux" >> +KERNEL_FILE ?= "${@ 'vmlinux' if d.getVar('DISTRO_ARCH') in ['mipsel', 'riscv64', 'arm64'] else 'vmlinuz'}" > Thanks, that's how I envisioned it. > > Felix > >> >> MACHINEOVERRIDES ?= "${MACHINE}" >> DISTROOVERRIDES ?= "${DISTRO}" >> -- >> 2.34.1 -- You received this message because you are subscribed to the Google Groups "isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/isar-users/edc58793-fc61-45ce-ae36-33212ae6f196%40ilbers.de. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] meta: Remove overrides from kernel filename selection 2026-05-28 14:20 ` 'MOESSBAUER, Felix' via isar-users 2026-05-28 14:23 ` Anton Mikanovich @ 2026-06-08 6:26 ` 'Jan Kiszka' via isar-users 2026-06-08 6:43 ` Anton Mikanovich 1 sibling, 1 reply; 10+ messages in thread From: 'Jan Kiszka' via isar-users @ 2026-06-08 6:26 UTC (permalink / raw) To: MOESSBAUER, Felix, amikan, isar-users On 28.05.26 16:20, 'MOESSBAUER, Felix' via isar-users wrote: > On Thu, 2026-05-28 at 16:56 +0300, Anton Mikanovich wrote: >> Because of the override processing logic values set by overrides can be >> changed only by overrides. It makes redifinition of KERNEL_FILE value >> made by simple assignment be ignored, which was already broken for the >> rpi-arm64-v8 machine. >> >> Rebuild selection logic to be done in bitbake.conf without overrides. >> Keep KERNEL_FILE redifinition for the rpi targets as an example of its >> usage for the downstreams. >> >> Signed-off-by: Anton Mikanovich <amikan@ilbers.de> >> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com> >> --- >> meta/classes-recipe/linux-kernel.bbclass | 3 --- >> meta/conf/bitbake.conf | 5 +---- >> 2 files changed, 1 insertion(+), 7 deletions(-) >> >> diff --git a/meta/classes-recipe/linux-kernel.bbclass b/meta/classes-recipe/linux-kernel.bbclass >> index 55ea6d63..e4ae356d 100644 >> --- a/meta/classes-recipe/linux-kernel.bbclass >> +++ b/meta/classes-recipe/linux-kernel.bbclass >> @@ -211,9 +211,6 @@ def get_kernel_arch(d): >> >> KERNEL_ARCH ??= "${@get_kernel_arch(d)}" >> >> -# set KERNEL_FILE without depending on package arch used in bitbake.conf >> -KERNEL_FILE:forcevariable = "${@ 'vmlinux' if d.getVar('KERNEL_ARCH') in ['mipsel', 'riscv', 'arm64'] else 'vmlinuz'}" > > Shall we remove the forcevariable override as well? At least in isar > this was the last remaining user. > forcevariable is a generic OE concept that we should continue to support. Our downstream users may expect it to work as before. But this removal above likely reintroduces the bug it fixed in fc99297b40eb. Did you actually check against that case? Sorry, seen this too late, but reading the git history is what I would have expected. And if you did, you must refer to it, explaining why a revert is fine. So, this should have likely NOT be merged... Jan >> - >> KERNEL_CONFIG_FRAGMENTS ?= "" >> >> def config_fragments(d): >> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf >> index 08c525d9..6db10eb3 100644 >> --- a/meta/conf/bitbake.conf >> +++ b/meta/conf/bitbake.conf >> @@ -65,10 +65,7 @@ SCHROOT_HOST_DIR = "${DEPLOY_DIR}/schroot-host/${HOST_DISTRO}-${HOST_ARCH}_${DIS >> SCHROOT_TARGET_DIR = "${DEPLOY_DIR}/schroot-target/${DISTRO}-${DISTRO_ARCH}" >> SDKCHROOT_DIR = "${DEPLOY_DIR_SDKCHROOT}/${BPN}-${DISTRO}-${MACHINE}" >> CACHE = "${TMPDIR}/cache" >> -KERNEL_FILE ?= "vmlinuz" >> -KERNEL_FILE:mipsel ?= "vmlinux" >> -KERNEL_FILE:riscv64 ?= "vmlinux" >> -KERNEL_FILE:arm64 ?= "vmlinux" >> +KERNEL_FILE ?= "${@ 'vmlinux' if d.getVar('DISTRO_ARCH') in ['mipsel', 'riscv64', 'arm64'] else 'vmlinuz'}" > > Thanks, that's how I envisioned it. > > Felix > >> >> MACHINEOVERRIDES ?= "${MACHINE}" >> DISTROOVERRIDES ?= "${DISTRO}" >> -- >> 2.34.1 > -- Siemens AG, Foundational Technologies Linux Expert Center -- You received this message because you are subscribed to the Google Groups "isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/isar-users/dd8a5bf4-dd81-4c06-8179-d95e1d16d328%40siemens.com. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] meta: Remove overrides from kernel filename selection 2026-06-08 6:26 ` 'Jan Kiszka' via isar-users @ 2026-06-08 6:43 ` Anton Mikanovich 2026-06-08 7:34 ` 'Jan Kiszka' via isar-users 0 siblings, 1 reply; 10+ messages in thread From: Anton Mikanovich @ 2026-06-08 6:43 UTC (permalink / raw) To: Jan Kiszka, MOESSBAUER, Felix, isar-users 08.06.2026 09:26, Jan Kiszka wrote: > On 28.05.26 16:20, 'MOESSBAUER, Felix' via isar-users wrote: >> On Thu, 2026-05-28 at 16:56 +0300, Anton Mikanovich wrote: >>> Because of the override processing logic values set by overrides can be >>> changed only by overrides. It makes redifinition of KERNEL_FILE value >>> made by simple assignment be ignored, which was already broken for the >>> rpi-arm64-v8 machine. >>> >>> Rebuild selection logic to be done in bitbake.conf without overrides. >>> Keep KERNEL_FILE redifinition for the rpi targets as an example of its >>> usage for the downstreams. >>> >>> Signed-off-by: Anton Mikanovich <amikan@ilbers.de> >>> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com> >>> --- >>> meta/classes-recipe/linux-kernel.bbclass | 3 --- >>> meta/conf/bitbake.conf | 5 +---- >>> 2 files changed, 1 insertion(+), 7 deletions(-) >>> >>> diff --git a/meta/classes-recipe/linux-kernel.bbclass b/meta/classes-recipe/linux-kernel.bbclass >>> index 55ea6d63..e4ae356d 100644 >>> --- a/meta/classes-recipe/linux-kernel.bbclass >>> +++ b/meta/classes-recipe/linux-kernel.bbclass >>> @@ -211,9 +211,6 @@ def get_kernel_arch(d): >>> >>> KERNEL_ARCH ??= "${@get_kernel_arch(d)}" >>> >>> -# set KERNEL_FILE without depending on package arch used in bitbake.conf >>> -KERNEL_FILE:forcevariable = "${@ 'vmlinux' if d.getVar('KERNEL_ARCH') in ['mipsel', 'riscv', 'arm64'] else 'vmlinuz'}" >> Shall we remove the forcevariable override as well? At least in isar >> this was the last remaining user. >> > forcevariable is a generic OE concept that we should continue to > support. Our downstream users may expect it to work as before. > > But this removal above likely reintroduces the bug it fixed in > fc99297b40eb. Did you actually check against that case? Sorry, seen this > too late, but reading the git history is what I would have expected. And > if you did, you must refer to it, explaining why a revert is fine. I've tried to build native kernels and it looks like everything is fine. Unfortunately fc99297 do not mention any real targets and don't have a test case, so I can't be 100% sure it isn't broken. > > So, this should have likely NOT be merged... > > Jan > >>> - >>> KERNEL_CONFIG_FRAGMENTS ?= "" >>> >>> def config_fragments(d): >>> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf >>> index 08c525d9..6db10eb3 100644 >>> --- a/meta/conf/bitbake.conf >>> +++ b/meta/conf/bitbake.conf >>> @@ -65,10 +65,7 @@ SCHROOT_HOST_DIR = "${DEPLOY_DIR}/schroot-host/${HOST_DISTRO}-${HOST_ARCH}_${DIS >>> SCHROOT_TARGET_DIR = "${DEPLOY_DIR}/schroot-target/${DISTRO}-${DISTRO_ARCH}" >>> SDKCHROOT_DIR = "${DEPLOY_DIR_SDKCHROOT}/${BPN}-${DISTRO}-${MACHINE}" >>> CACHE = "${TMPDIR}/cache" >>> -KERNEL_FILE ?= "vmlinuz" >>> -KERNEL_FILE:mipsel ?= "vmlinux" >>> -KERNEL_FILE:riscv64 ?= "vmlinux" >>> -KERNEL_FILE:arm64 ?= "vmlinux" >>> +KERNEL_FILE ?= "${@ 'vmlinux' if d.getVar('DISTRO_ARCH') in ['mipsel', 'riscv64', 'arm64'] else 'vmlinuz'}" >> Thanks, that's how I envisioned it. >> >> Felix >> >>> >>> MACHINEOVERRIDES ?= "${MACHINE}" >>> DISTROOVERRIDES ?= "${DISTRO}" >>> -- >>> 2.34.1 > -- You received this message because you are subscribed to the Google Groups "isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/isar-users/f598b607-adea-4b4c-ad4f-3697b10d11c6%40ilbers.de. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] meta: Remove overrides from kernel filename selection 2026-06-08 6:43 ` Anton Mikanovich @ 2026-06-08 7:34 ` 'Jan Kiszka' via isar-users 2026-06-08 8:13 ` 'Jan Kiszka' via isar-users 0 siblings, 1 reply; 10+ messages in thread From: 'Jan Kiszka' via isar-users @ 2026-06-08 7:34 UTC (permalink / raw) To: Anton Mikanovich, MOESSBAUER, Felix, isar-users On 08.06.26 08:43, Anton Mikanovich wrote: > 08.06.2026 09:26, Jan Kiszka wrote: >> On 28.05.26 16:20, 'MOESSBAUER, Felix' via isar-users wrote: >>> On Thu, 2026-05-28 at 16:56 +0300, Anton Mikanovich wrote: >>>> Because of the override processing logic values set by overrides can be >>>> changed only by overrides. It makes redifinition of KERNEL_FILE value >>>> made by simple assignment be ignored, which was already broken for the >>>> rpi-arm64-v8 machine. >>>> >>>> Rebuild selection logic to be done in bitbake.conf without overrides. >>>> Keep KERNEL_FILE redifinition for the rpi targets as an example of its >>>> usage for the downstreams. >>>> >>>> Signed-off-by: Anton Mikanovich <amikan@ilbers.de> >>>> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com> >>>> --- >>>> meta/classes-recipe/linux-kernel.bbclass | 3 --- >>>> meta/conf/bitbake.conf | 5 +---- >>>> 2 files changed, 1 insertion(+), 7 deletions(-) >>>> >>>> diff --git a/meta/classes-recipe/linux-kernel.bbclass b/meta/ >>>> classes-recipe/linux-kernel.bbclass >>>> index 55ea6d63..e4ae356d 100644 >>>> --- a/meta/classes-recipe/linux-kernel.bbclass >>>> +++ b/meta/classes-recipe/linux-kernel.bbclass >>>> @@ -211,9 +211,6 @@ def get_kernel_arch(d): >>>> KERNEL_ARCH ??= "${@get_kernel_arch(d)}" >>>> -# set KERNEL_FILE without depending on package arch used in >>>> bitbake.conf >>>> -KERNEL_FILE:forcevariable = "${@ 'vmlinux' if >>>> d.getVar('KERNEL_ARCH') in ['mipsel', 'riscv', 'arm64'] else >>>> 'vmlinuz'}" >>> Shall we remove the forcevariable override as well? At least in isar >>> this was the last remaining user. >>> >> forcevariable is a generic OE concept that we should continue to >> support. Our downstream users may expect it to work as before. >> >> But this removal above likely reintroduces the bug it fixed in >> fc99297b40eb. Did you actually check against that case? Sorry, seen this >> too late, but reading the git history is what I would have expected. And >> if you did, you must refer to it, explaining why a revert is fine. > I've tried to build native kernels and it looks like everything is fine. > Unfortunately fc99297 do not mention any real targets and don't have a test > case, so I can't be 100% sure it isn't broken. Did you check the resuling KERNEL_FILE for, say, riscv in case of building -native? If that is still correct, would be good to leave a reasoning behind, why. Jan -- Siemens AG, Foundational Technologies Linux Expert Center -- You received this message because you are subscribed to the Google Groups "isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/isar-users/4327cb19-ae95-4c63-95ec-246a4b2cff6d%40siemens.com. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] meta: Remove overrides from kernel filename selection 2026-06-08 7:34 ` 'Jan Kiszka' via isar-users @ 2026-06-08 8:13 ` 'Jan Kiszka' via isar-users 2026-06-08 9:25 ` 'MOESSBAUER, Felix' via isar-users 0 siblings, 1 reply; 10+ messages in thread From: 'Jan Kiszka' via isar-users @ 2026-06-08 8:13 UTC (permalink / raw) To: Anton Mikanovich, MOESSBAUER, Felix, isar-users On 08.06.26 09:34, 'Jan Kiszka' via isar-users wrote: > On 08.06.26 08:43, Anton Mikanovich wrote: >> 08.06.2026 09:26, Jan Kiszka wrote: >>> On 28.05.26 16:20, 'MOESSBAUER, Felix' via isar-users wrote: >>>> On Thu, 2026-05-28 at 16:56 +0300, Anton Mikanovich wrote: >>>>> Because of the override processing logic values set by overrides can be >>>>> changed only by overrides. It makes redifinition of KERNEL_FILE value >>>>> made by simple assignment be ignored, which was already broken for the >>>>> rpi-arm64-v8 machine. >>>>> >>>>> Rebuild selection logic to be done in bitbake.conf without overrides. >>>>> Keep KERNEL_FILE redifinition for the rpi targets as an example of its >>>>> usage for the downstreams. >>>>> >>>>> Signed-off-by: Anton Mikanovich <amikan@ilbers.de> >>>>> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com> >>>>> --- >>>>> meta/classes-recipe/linux-kernel.bbclass | 3 --- >>>>> meta/conf/bitbake.conf | 5 +---- >>>>> 2 files changed, 1 insertion(+), 7 deletions(-) >>>>> >>>>> diff --git a/meta/classes-recipe/linux-kernel.bbclass b/meta/ >>>>> classes-recipe/linux-kernel.bbclass >>>>> index 55ea6d63..e4ae356d 100644 >>>>> --- a/meta/classes-recipe/linux-kernel.bbclass >>>>> +++ b/meta/classes-recipe/linux-kernel.bbclass >>>>> @@ -211,9 +211,6 @@ def get_kernel_arch(d): >>>>> KERNEL_ARCH ??= "${@get_kernel_arch(d)}" >>>>> -# set KERNEL_FILE without depending on package arch used in >>>>> bitbake.conf >>>>> -KERNEL_FILE:forcevariable = "${@ 'vmlinux' if >>>>> d.getVar('KERNEL_ARCH') in ['mipsel', 'riscv', 'arm64'] else >>>>> 'vmlinuz'}" >>>> Shall we remove the forcevariable override as well? At least in isar >>>> this was the last remaining user. >>>> >>> forcevariable is a generic OE concept that we should continue to >>> support. Our downstream users may expect it to work as before. >>> >>> But this removal above likely reintroduces the bug it fixed in >>> fc99297b40eb. Did you actually check against that case? Sorry, seen this >>> too late, but reading the git history is what I would have expected. And >>> if you did, you must refer to it, explaining why a revert is fine. >> I've tried to build native kernels and it looks like everything is fine. >> Unfortunately fc99297 do not mention any real targets and don't have a test >> case, so I can't be 100% sure it isn't broken. > > Did you check the resuling KERNEL_FILE for, say, riscv in case of > building -native? If that is still correct, would be good to leave a > reasoning behind, why. > So, the patch is fine, though only by luck, not by analysis: Overrides work per PACKAGE_ARCH, and the -native package for a kernel has HOST_DISTRO_ARCH here. That is why the old logic needed that fix-up. The new one uses DISTRO_ARCH, thus is not affected by the -native differences. BTW, my patch had a bug: KERNEL_ARCH = mips, not mipsel. That is now auto-fixed as well Jan -- Siemens AG, Foundational Technologies Linux Expert Center -- You received this message because you are subscribed to the Google Groups "isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/isar-users/b684d974-5e43-45c6-8605-bc03c81d71f8%40siemens.com. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] meta: Remove overrides from kernel filename selection 2026-06-08 8:13 ` 'Jan Kiszka' via isar-users @ 2026-06-08 9:25 ` 'MOESSBAUER, Felix' via isar-users 2026-06-08 9:57 ` 'Jan Kiszka' via isar-users 0 siblings, 1 reply; 10+ messages in thread From: 'MOESSBAUER, Felix' via isar-users @ 2026-06-08 9:25 UTC (permalink / raw) To: Kiszka, Jan, amikan, isar-users On Mon, 2026-06-08 at 10:13 +0200, Jan Kiszka wrote: > On 08.06.26 09:34, 'Jan Kiszka' via isar-users wrote: > > On 08.06.26 08:43, Anton Mikanovich wrote: > > > 08.06.2026 09:26, Jan Kiszka wrote: > > > > On 28.05.26 16:20, 'MOESSBAUER, Felix' via isar-users wrote: > > > > > On Thu, 2026-05-28 at 16:56 +0300, Anton Mikanovich wrote: > > > > > > Because of the override processing logic values set by overrides can be > > > > > > changed only by overrides. It makes redifinition of KERNEL_FILE value > > > > > > made by simple assignment be ignored, which was already broken for the > > > > > > rpi-arm64-v8 machine. > > > > > > > > > > > > Rebuild selection logic to be done in bitbake.conf without overrides. > > > > > > Keep KERNEL_FILE redifinition for the rpi targets as an example of its > > > > > > usage for the downstreams. > > > > > > > > > > > > Signed-off-by: Anton Mikanovich <amikan@ilbers.de> > > > > > > Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com> > > > > > > --- > > > > > > meta/classes-recipe/linux-kernel.bbclass | 3 --- > > > > > > meta/conf/bitbake.conf | 5 +---- > > > > > > 2 files changed, 1 insertion(+), 7 deletions(-) > > > > > > > > > > > > diff --git a/meta/classes-recipe/linux-kernel.bbclass b/meta/ > > > > > > classes-recipe/linux-kernel.bbclass > > > > > > index 55ea6d63..e4ae356d 100644 > > > > > > --- a/meta/classes-recipe/linux-kernel.bbclass > > > > > > +++ b/meta/classes-recipe/linux-kernel.bbclass > > > > > > @@ -211,9 +211,6 @@ def get_kernel_arch(d): > > > > > > KERNEL_ARCH ??= "${@get_kernel_arch(d)}" > > > > > > -# set KERNEL_FILE without depending on package arch used in > > > > > > bitbake.conf > > > > > > -KERNEL_FILE:forcevariable = "${@ 'vmlinux' if > > > > > > d.getVar('KERNEL_ARCH') in ['mipsel', 'riscv', 'arm64'] else > > > > > > 'vmlinuz'}" > > > > > Shall we remove the forcevariable override as well? At least in isar > > > > > this was the last remaining user. > > > > > > > > > forcevariable is a generic OE concept that we should continue to > > > > support. Our downstream users may expect it to work as before. > > > > > > > > But this removal above likely reintroduces the bug it fixed in > > > > fc99297b40eb. Did you actually check against that case? Sorry, seen this > > > > too late, but reading the git history is what I would have expected. And > > > > if you did, you must refer to it, explaining why a revert is fine. > > > I've tried to build native kernels and it looks like everything is fine. > > > Unfortunately fc99297 do not mention any real targets and don't have a test > > > case, so I can't be 100% sure it isn't broken. > > > > Did you check the resuling KERNEL_FILE for, say, riscv in case of > > building -native? If that is still correct, would be good to leave a > > reasoning behind, why. > > > > So, the patch is fine, though only by luck, not by analysis: > > Overrides work per PACKAGE_ARCH, and the -native package for a kernel > has HOST_DISTRO_ARCH here. That is why the old logic needed that fix-up. > The new one uses DISTRO_ARCH, thus is not affected by the -native > differences. What is HOST_DISTRO_ARCH, I can't find this in any commit? Is that HOST_ARCH? Thanks for the analysis. Still, I'm wondering what exactly must be built to expose this? Is a simple kernel crosscompile for riscv sufficient? Felix > > BTW, my patch had a bug: KERNEL_ARCH = mips, not mipsel. That is now > auto-fixed as well > > Jan > > -- > Siemens AG, Foundational Technologies > Linux Expert Center -- You received this message because you are subscribed to the Google Groups "isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/isar-users/61c0f6ad244a1cc06787c1775de602f14925f525.camel%40siemens.com. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] meta: Remove overrides from kernel filename selection 2026-06-08 9:25 ` 'MOESSBAUER, Felix' via isar-users @ 2026-06-08 9:57 ` 'Jan Kiszka' via isar-users 0 siblings, 0 replies; 10+ messages in thread From: 'Jan Kiszka' via isar-users @ 2026-06-08 9:57 UTC (permalink / raw) To: Moessbauer, Felix (FT RPD CED OES-DE), amikan, isar-users On 08.06.26 11:25, Moessbauer, Felix (FT RPD CED OES-DE) wrote: > On Mon, 2026-06-08 at 10:13 +0200, Jan Kiszka wrote: >> On 08.06.26 09:34, 'Jan Kiszka' via isar-users wrote: >>> On 08.06.26 08:43, Anton Mikanovich wrote: >>>> 08.06.2026 09:26, Jan Kiszka wrote: >>>>> On 28.05.26 16:20, 'MOESSBAUER, Felix' via isar-users wrote: >>>>>> On Thu, 2026-05-28 at 16:56 +0300, Anton Mikanovich wrote: >>>>>>> Because of the override processing logic values set by overrides can be >>>>>>> changed only by overrides. It makes redifinition of KERNEL_FILE value >>>>>>> made by simple assignment be ignored, which was already broken for the >>>>>>> rpi-arm64-v8 machine. >>>>>>> >>>>>>> Rebuild selection logic to be done in bitbake.conf without overrides. >>>>>>> Keep KERNEL_FILE redifinition for the rpi targets as an example of its >>>>>>> usage for the downstreams. >>>>>>> >>>>>>> Signed-off-by: Anton Mikanovich <amikan@ilbers.de> >>>>>>> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com> >>>>>>> --- >>>>>>> meta/classes-recipe/linux-kernel.bbclass | 3 --- >>>>>>> meta/conf/bitbake.conf | 5 +---- >>>>>>> 2 files changed, 1 insertion(+), 7 deletions(-) >>>>>>> >>>>>>> diff --git a/meta/classes-recipe/linux-kernel.bbclass b/meta/ >>>>>>> classes-recipe/linux-kernel.bbclass >>>>>>> index 55ea6d63..e4ae356d 100644 >>>>>>> --- a/meta/classes-recipe/linux-kernel.bbclass >>>>>>> +++ b/meta/classes-recipe/linux-kernel.bbclass >>>>>>> @@ -211,9 +211,6 @@ def get_kernel_arch(d): >>>>>>> KERNEL_ARCH ??= "${@get_kernel_arch(d)}" >>>>>>> -# set KERNEL_FILE without depending on package arch used in >>>>>>> bitbake.conf >>>>>>> -KERNEL_FILE:forcevariable = "${@ 'vmlinux' if >>>>>>> d.getVar('KERNEL_ARCH') in ['mipsel', 'riscv', 'arm64'] else >>>>>>> 'vmlinuz'}" >>>>>> Shall we remove the forcevariable override as well? At least in isar >>>>>> this was the last remaining user. >>>>>> >>>>> forcevariable is a generic OE concept that we should continue to >>>>> support. Our downstream users may expect it to work as before. >>>>> >>>>> But this removal above likely reintroduces the bug it fixed in >>>>> fc99297b40eb. Did you actually check against that case? Sorry, seen this >>>>> too late, but reading the git history is what I would have expected. And >>>>> if you did, you must refer to it, explaining why a revert is fine. >>>> I've tried to build native kernels and it looks like everything is fine. >>>> Unfortunately fc99297 do not mention any real targets and don't have a test >>>> case, so I can't be 100% sure it isn't broken. >>> >>> Did you check the resuling KERNEL_FILE for, say, riscv in case of >>> building -native? If that is still correct, would be good to leave a >>> reasoning behind, why. >>> >> >> So, the patch is fine, though only by luck, not by analysis: >> >> Overrides work per PACKAGE_ARCH, and the -native package for a kernel >> has HOST_DISTRO_ARCH here. That is why the old logic needed that fix-up. >> The new one uses DISTRO_ARCH, thus is not affected by the -native >> differences. > > What is HOST_DISTRO_ARCH, I can't find this in any commit? Is that > HOST_ARCH? > My AI must have hallucinated this: HOST_ARCH. > Thanks for the analysis. Still, I'm wondering what exactly must be > built to expose this? Is a simple kernel crosscompile for riscv > sufficient? I built over fc99297b40eb0ac4b741926fa399d9b5eaaaf825^ linux-starfive-native, and KERNEL_FILE was vmlinu*z*. Jan -- Siemens AG, Foundational Technologies Linux Expert Center -- You received this message because you are subscribed to the Google Groups "isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/isar-users/d7c43403-4366-4467-afb0-dc69eb7a8800%40siemens.com. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] meta: Remove overrides from kernel filename selection 2026-05-28 13:56 [PATCH] meta: Remove overrides from kernel filename selection Anton Mikanovich 2026-05-28 14:20 ` 'MOESSBAUER, Felix' via isar-users @ 2026-06-08 6:13 ` Anton Mikanovich 1 sibling, 0 replies; 10+ messages in thread From: Anton Mikanovich @ 2026-06-08 6:13 UTC (permalink / raw) To: isar-users; +Cc: Felix Moessbauer 28.05.2026 16:56, Anton Mikanovich wrote: > Because of the override processing logic values set by overrides can be > changed only by overrides. It makes redifinition of KERNEL_FILE value > made by simple assignment be ignored, which was already broken for the > rpi-arm64-v8 machine. > > Rebuild selection logic to be done in bitbake.conf without overrides. > Keep KERNEL_FILE redifinition for the rpi targets as an example of its > usage for the downstreams. > > Signed-off-by: Anton Mikanovich <amikan@ilbers.de> > Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com> Applied to next. -- You received this message because you are subscribed to the Google Groups "isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/isar-users/a052f316-5734-48d6-826a-1ff6843adf8f%40ilbers.de. ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2026-06-08 9:57 UTC | newest] Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2026-05-28 13:56 [PATCH] meta: Remove overrides from kernel filename selection Anton Mikanovich 2026-05-28 14:20 ` 'MOESSBAUER, Felix' via isar-users 2026-05-28 14:23 ` Anton Mikanovich 2026-06-08 6:26 ` 'Jan Kiszka' via isar-users 2026-06-08 6:43 ` Anton Mikanovich 2026-06-08 7:34 ` 'Jan Kiszka' via isar-users 2026-06-08 8:13 ` 'Jan Kiszka' via isar-users 2026-06-08 9:25 ` 'MOESSBAUER, Felix' via isar-users 2026-06-08 9:57 ` 'Jan Kiszka' via isar-users 2026-06-08 6:13 ` Anton Mikanovich
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox