public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
* [PATCH] example-module: use pr_info instead of printk
@ 2026-04-10 16:50 srinuvasan.a via isar-users
  2026-04-10 17:41 ` 'Jan Kiszka' via isar-users
  0 siblings, 1 reply; 3+ messages in thread
From: srinuvasan.a via isar-users @ 2026-04-10 16:50 UTC (permalink / raw)
  To: isar-users; +Cc: Srinuvasan A

From: Srinuvasan A <srinuvasan.a@siemens.com>

The initialization message was not visible in dmesg
when the module was loaded.

Switch to pr_info() to ensure the message is properly
logged and visible during module initialization.

Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com>
---
 .../recipes-kernel/example-module/files/src/example-module.c    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-isar/recipes-kernel/example-module/files/src/example-module.c b/meta-isar/recipes-kernel/example-module/files/src/example-module.c
index 4e74ee74..5a408726 100644
--- a/meta-isar/recipes-kernel/example-module/files/src/example-module.c
+++ b/meta-isar/recipes-kernel/example-module/files/src/example-module.c
@@ -10,7 +10,7 @@
 
 static int __init example_module_init(void)
 {
-	printk("Just an example\n");
+	pr_info("Just an example\n");
 	return 0;
 }
 
-- 
2.34.1

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/20260410165048.438922-1-srinuvasan.a%40siemens.com.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] example-module: use pr_info instead of printk
  2026-04-10 16:50 [PATCH] example-module: use pr_info instead of printk srinuvasan.a via isar-users
@ 2026-04-10 17:41 ` 'Jan Kiszka' via isar-users
  2026-04-17  5:03   ` 'Arjunan, Srinu' via isar-users
  0 siblings, 1 reply; 3+ messages in thread
From: 'Jan Kiszka' via isar-users @ 2026-04-10 17:41 UTC (permalink / raw)
  To: srinuvasan.a, isar-users

On 10.04.26 18:50, srinuvasan.a via isar-users wrote:
> From: Srinuvasan A <srinuvasan.a@siemens.com>
> 
> The initialization message was not visible in dmesg
> when the module was loaded.

That is a matter of log level settings on the target. We can still
change this if it helps.

> 
> Switch to pr_info() to ensure the message is properly
> logged and visible during module initialization.
> 

Which test case in Isar was affected by this? Or was this a downstream
target?

> Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com>
> ---
>  .../recipes-kernel/example-module/files/src/example-module.c    | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-isar/recipes-kernel/example-module/files/src/example-module.c b/meta-isar/recipes-kernel/example-module/files/src/example-module.c
> index 4e74ee74..5a408726 100644
> --- a/meta-isar/recipes-kernel/example-module/files/src/example-module.c
> +++ b/meta-isar/recipes-kernel/example-module/files/src/example-module.c
> @@ -10,7 +10,7 @@
>  
>  static int __init example_module_init(void)
>  {
> -	printk("Just an example\n");
> +	pr_info("Just an example\n");
>  	return 0;
>  }
>  

Jan

-- 
Siemens AG, Foundational Technologies
Linux Expert Center

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/f42da35e-002b-4247-9f23-9172c4554916%40siemens.com.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH] example-module: use pr_info instead of printk
  2026-04-10 17:41 ` 'Jan Kiszka' via isar-users
@ 2026-04-17  5:03   ` 'Arjunan, Srinu' via isar-users
  0 siblings, 0 replies; 3+ messages in thread
From: 'Arjunan, Srinu' via isar-users @ 2026-04-17  5:03 UTC (permalink / raw)
  To: Kiszka, Jan, isar-users

> Which test case in Isar was affected by this? Or was this a downstream target?

No Isar test cases are affected, this was observed only on a downstream target.

Your point is valid — we will look into adjusting the log level settings on our target instead of unconditionally ensuring the message appears in dmesg.

Many thanks,
Srinu

-----Original Message-----
From: Kiszka, Jan (FT RPD CED) <jan.kiszka@siemens.com> 
Sent: 10 April 2026 23:12
To: Arjunan, Srinu (FT FDS CES LX PBU 2) <srinuvasan.a@siemens.com>; isar-users@googlegroups.com
Subject: Re: [PATCH] example-module: use pr_info instead of printk

On 10.04.26 18:50, srinuvasan.a via isar-users wrote:
> From: Srinuvasan A <srinuvasan.a@siemens.com>
> 
> The initialization message was not visible in dmesg when the module 
> was loaded.

That is a matter of log level settings on the target. We can still change this if it helps.

> 
> Switch to pr_info() to ensure the message is properly logged and 
> visible during module initialization.
> 

Which test case in Isar was affected by this? Or was this a downstream target?

> Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com>
> ---
>  .../recipes-kernel/example-module/files/src/example-module.c    | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git 
> a/meta-isar/recipes-kernel/example-module/files/src/example-module.c 
> b/meta-isar/recipes-kernel/example-module/files/src/example-module.c
> index 4e74ee74..5a408726 100644
> --- 
> a/meta-isar/recipes-kernel/example-module/files/src/example-module.c
> +++ b/meta-isar/recipes-kernel/example-module/files/src/example-module
> +++ .c
> @@ -10,7 +10,7 @@
>  
>  static int __init example_module_init(void)  {
> -	printk("Just an example\n");
> +	pr_info("Just an example\n");
>  	return 0;
>  }
>  

Jan

--
Siemens AG, Foundational Technologies
Linux Expert Center

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/PUZPR06MB5747997780C8A84F7C50692D88202%40PUZPR06MB5747.apcprd06.prod.outlook.com.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-04-17  5:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-04-10 16:50 [PATCH] example-module: use pr_info instead of printk srinuvasan.a via isar-users
2026-04-10 17:41 ` 'Jan Kiszka' via isar-users
2026-04-17  5:03   ` 'Arjunan, Srinu' via isar-users

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox