public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "'Felix Moessbauer' via isar-users" <isar-users@googlegroups.com>
To: isar-users@googlegroups.com
Cc: jan.kiszka@siemens.com, Felix Moessbauer <felix.moessbauer@siemens.com>
Subject: [PATCH 1/2] isar-sstate: lint task flags as well
Date: Thu, 24 Sep 2026 08:45:46 +0200	[thread overview]
Message-ID: <20260924064547.4017118-1-felix.moessbauer@siemens.com> (raw)

We previously only linted all uppercase variables, but by that we missed
absolute path in task flags (e.g. do_unpack[cleandirs]). Lint them as
well.

The exact reason why we only linted the uppercase variables remains
unclear. On todays caches, this neither has a significant performance
impact, nor does it report false positives.

Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
---
 scripts/isar-sstate | 2 --
 1 file changed, 2 deletions(-)

diff --git a/scripts/isar-sstate b/scripts/isar-sstate
index ada154e2..5d7b8ebc 100755
--- a/scripts/isar-sstate
+++ b/scripts/isar-sstate
@@ -894,8 +894,6 @@ def sstate_lint(target, verbose, sources_dir, build_dir, exit_code, pedantic, li
 
         pn_issues = []
         for name, val in sigdata['varvals'].items():
-            if not name[0].isupper():
-                continue
             if sigdata['basehash_ignore_vars'] and name in sigdata['basehash_ignore_vars'] or \
                sigdata['taskhash_ignore_tasks'] and name in sigdata['taskhash_ignore_tasks'] or \
                name in ADDITIONAL_IGNORED_VARNAMES:
-- 
2.55.0

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/20260924064547.4017118-1-felix.moessbauer%40siemens.com.

             reply	other threads:[~2026-09-24  6:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-24  6:45 'Felix Moessbauer' via isar-users [this message]
2026-09-24  6:45 ` [PATCH 2/2] do_unpack: do not expand S to avoid absolute path in signatures 'Felix Moessbauer' via isar-users
2026-10-06 10:25 ` [PATCH 1/2] isar-sstate: lint task flags as well Zhihang Wei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260924064547.4017118-1-felix.moessbauer@siemens.com \
    --to=isar-users@googlegroups.com \
    --cc=felix.moessbauer@siemens.com \
    --cc=jan.kiszka@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox