Re: [PATCH 1/2] isar-sstate: lint task flags as well

[Zhihang Wei <wzh@ilbers.de>]

Applied to next, thanks.

Zhihang

On 9/24/26 08:45, 'Felix Moessbauer' via isar-users wrote:
> We previously only linted all uppercase variables, but by that we missed
> absolute path in task flags (e.g. do_unpack[cleandirs]). Lint them as
> well.
>
> The exact reason why we only linted the uppercase variables remains
> unclear. On todays caches, this neither has a significant performance
> impact, nor does it report false positives.
>
> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> ---
>   scripts/isar-sstate | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/scripts/isar-sstate b/scripts/isar-sstate
> index ada154e2..5d7b8ebc 100755
> --- a/scripts/isar-sstate
> +++ b/scripts/isar-sstate
> @@ -894,8 +894,6 @@ def sstate_lint(target, verbose, sources_dir, build_dir, exit_code, pedantic, li
>   
>           pn_issues = []
>           for name, val in sigdata['varvals'].items():
> -            if not name[0].isupper():
> -                continue
>               if sigdata['basehash_ignore_vars'] and name in sigdata['basehash_ignore_vars'] or \
>                  sigdata['taskhash_ignore_tasks'] and name in sigdata['taskhash_ignore_tasks'] or \
>                  name in ADDITIONAL_IGNORED_VARNAMES:

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/8b374312-1735-43d6-b5bd-26142ff4cffa%40ilbers.de.