public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "'Felix Moessbauer' via isar-users" <isar-users@googlegroups.com>
To: isar-users@googlegroups.com
Cc: jan.kiszka@siemens.com, Felix Moessbauer <felix.moessbauer@siemens.com>
Subject: [PATCH 2/2] do_unpack: do not expand S to avoid absolute path in signatures
Date: Thu, 24 Sep 2026 08:45:47 +0200	[thread overview]
Message-ID: <20260924064547.4017118-2-felix.moessbauer@siemens.com> (raw)
In-Reply-To: <20260924064547.4017118-1-felix.moessbauer@siemens.com>

We currently fully expand S before passing it to do_unpack. This makes
all packages that depend on the apt fetcher not cacheable, as the
absolute path ends up in the sstate signatures. Instead, we now use the
unexpanded bitbake variable ${S}.

Fixes: 37cb017a ("Convert apt source fetcher into native ...")
Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
---
 meta/classes-recipe/dpkg-base.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes-recipe/dpkg-base.bbclass b/meta/classes-recipe/dpkg-base.bbclass
index fbb952bd..b392211b 100644
--- a/meta/classes-recipe/dpkg-base.bbclass
+++ b/meta/classes-recipe/dpkg-base.bbclass
@@ -105,7 +105,7 @@ python() {
         if u.startswith("apt://"):
             d.appendVarFlag('do_fetch', 'depends', d.getVar('SCHROOT_DEP'))
 
-            d.appendVarFlag('do_unpack', 'cleandirs', d.getVar('S'))
+            d.appendVarFlag('do_unpack', 'cleandirs', '${S}')
             d.setVarFlag('do_unpack', 'network', d.getVar('TASK_USE_SUDO'))
             break
 
-- 
2.55.0

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/20260924064547.4017118-2-felix.moessbauer%40siemens.com.

  reply	other threads:[~2026-09-24  6:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-24  6:45 [PATCH 1/2] isar-sstate: lint task flags as well 'Felix Moessbauer' via isar-users
2026-09-24  6:45 ` 'Felix Moessbauer' via isar-users [this message]
2026-10-06 10:25 ` Zhihang Wei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260924064547.4017118-2-felix.moessbauer@siemens.com \
    --to=isar-users@googlegroups.com \
    --cc=felix.moessbauer@siemens.com \
    --cc=jan.kiszka@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox