[PATCH v2] Fix ZeroDivisionError for kernels without modules

[PATCH v2] Fix ZeroDivisionError for kernels without modules

['Stefan Koch' via isar-users]

Ensure that `num_pkgs` is at least 1 to avoid division by zero.

Fixes: 938dab36 ("Report approximate progress during initrd generation")

Signed-off-by: Stefan Koch <stefan-koch@siemens.com>
---
 meta/lib/rootfs_progress.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/lib/rootfs_progress.py b/meta/lib/rootfs_progress.py
index 6feed9df..58d16574 100644
--- a/meta/lib/rootfs_progress.py
+++ b/meta/lib/rootfs_progress.py
@@ -77,7 +77,7 @@ class InitrdProgressHandler(PkgsProgressHandler):
         m = re.search(r'^Total number of modules: ([0-9]+)', line)
         if m:
             # in MODULES=most mode, we install ~half of all modules
-            self._num_pkgs = int(m.group(1)) // 2
+            self._num_pkgs = max(1, int(m.group(1)) // 2)
             self._stage = 'post-prepare'
 
     def process_line(self, line):
-- 
2.47.3

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/20260417114032.1255396-1-stefan-koch%40siemens.com.

Re: [PATCH v2] Fix ZeroDivisionError for kernels without modules

['MOESSBAUER, Felix' via isar-users]

On Fri, 2026-04-17 at 13:40 +0200, Stefan Koch wrote:
> Ensure that `num_pkgs` is at least 1 to avoid division by zero.
> 
> Fixes: 938dab36 ("Report approximate progress during initrd generation")

Thanks!

Reviewed-by: Felix Moessbauer <felix.moessbauer@siemens.com>

This should also go into the v1.0.1 release.

Felix

> 
> Signed-off-by: Stefan Koch <stefan-koch@siemens.com>
> ---
>  meta/lib/rootfs_progress.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/lib/rootfs_progress.py b/meta/lib/rootfs_progress.py
> index 6feed9df..58d16574 100644
> --- a/meta/lib/rootfs_progress.py
> +++ b/meta/lib/rootfs_progress.py
> @@ -77,7 +77,7 @@ class InitrdProgressHandler(PkgsProgressHandler):
>          m = re.search(r'^Total number of modules: ([0-9]+)', line)
>          if m:
>              # in MODULES=most mode, we install ~half of all modules
> -            self._num_pkgs = int(m.group(1)) // 2
> +            self._num_pkgs = max(1, int(m.group(1)) // 2)
>              self._stage = 'post-prepare'
>  
>      def process_line(self, line):
> -- 
> 2.47.3

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/90eddff3bc46d2f426843c8adeb9b354f7e5cc5f.camel%40siemens.com.

Re: [PATCH v2] Fix ZeroDivisionError for kernels without modules

[Zhihang Wei]

Applied to next, thanks.

Zhihang

On 4/17/26 13:40, 'Stefan Koch' via isar-users wrote:
> Ensure that `num_pkgs` is at least 1 to avoid division by zero.
>
> Fixes: 938dab36 ("Report approximate progress during initrd generation")
>
> Signed-off-by: Stefan Koch <stefan-koch@siemens.com>
> ---
>   meta/lib/rootfs_progress.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/lib/rootfs_progress.py b/meta/lib/rootfs_progress.py
> index 6feed9df..58d16574 100644
> --- a/meta/lib/rootfs_progress.py
> +++ b/meta/lib/rootfs_progress.py
> @@ -77,7 +77,7 @@ class InitrdProgressHandler(PkgsProgressHandler):
>           m = re.search(r'^Total number of modules: ([0-9]+)', line)
>           if m:
>               # in MODULES=most mode, we install ~half of all modules
> -            self._num_pkgs = int(m.group(1)) // 2
> +            self._num_pkgs = max(1, int(m.group(1)) // 2)
>               self._stage = 'post-prepare'
>   
>       def process_line(self, line):

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/2ee995cf-88b4-4d84-98ba-4429ac37e254%40ilbers.de.