Re: [PATCH 1/1] Bugfix: add a check for "None" to raise a WicError

["'MOESSBAUER, Felix' via isar-users" <isar-users@googlegroups.com>]

On Wed, 2026-07-15 at 06:41 +0000, 'Ulrich Teichert' via isar-users
wrote:
> Add a check for "None" to raise a WicError because
> get_bitbake_var may return "None" if the variable is not available, which
> would result in an exception inside os.path.isdir and not to the WicError
> exception as intended.

Hi,

did you also send this patch to OE? Changes in the wic plugins that are
not purely isar related have to be accepted by OE first (to avoid that
our plugins diverge up to the point of not being able to update them
anymore).

Felix

> 
> Signed-off-by: Ulrich Teichert <ulrich.teichert@ebs-group.io> 
> 
> ---
>  scripts/lib/wic/plugins/source/rootfs.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/lib/wic/plugins/source/rootfs.py b/scripts/lib/wic/plugins/source/rootfs.py
> index e29f3a4c..977ac0d3 100644
> --- a/scripts/lib/wic/plugins/source/rootfs.py
> +++ b/scripts/lib/wic/plugins/source/rootfs.py
> @@ -54,7 +54,7 @@ class RootfsPlugin(SourcePlugin):
>              return os.path.realpath(rootfs_dir)
>  
>          image_rootfs_dir = get_bitbake_var("IMAGE_ROOTFS", rootfs_dir)
> -        if not os.path.isdir(image_rootfs_dir):
> +        if image_rootfs_dir == None or not os.path.isdir(image_rootfs_dir):
>              raise WicError("No valid artifact IMAGE_ROOTFS from image "
>                             "named %s has been found at %s, exiting." %
>                             (rootfs_dir, image_rootfs_dir))
> -- 
> 2.47.3
> 
> Mit
> besten Grüßen / Best regards 
> 
> Dipl.-Inform.
> Ulrich
> Teichert
> Senior
> Software Engineer
> 
> 
> T→ +49 431 375938-0
> ebs-group.io
> _____________________________________
> 
> 
> e.bs kumkeo
> GmbH
> 
> Am
> Kiel-Kanal 1 
> 
> 24106
> Kiel, Deutschland
> Geschäftsführer
> → Michael Leitner, Günter Hagspiel
> 
> Registergericht →
> Amtsgericht Hamburg
> 
> Registernummer → HRB 187712
> 
> USt-Idnr.
> → DE449906070
> 
> 
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups "isar-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
> To view this discussion visit https://groups.google.com/d/msgid/isar-users/DB9PR08MB744889FBE7B009B67B506A47C3F82%40DB9PR08MB7448.eurprd08.prod.outlook.com.

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/6428ffdeaf01d7abd00be74b10c537ccdbb0afa1.camel%40siemens.com.