From: "'Ulrich Teichert' via isar-users" <isar-users@googlegroups.com>
To: Isar <isar-users@googlegroups.com>,
"MOESSBAUER, Felix" <felix.moessbauer@siemens.com>
Cc: "krypton@ulrich-teichert.org" <krypton@ulrich-teichert.org>
Subject: Re: [PATCH 1/1] Bugfix: add a check for "None" to raise a WicError
Date: Wed, 15 Jul 2026 11:33:24 +0000 [thread overview]
Message-ID: <DB9PR08MB7448E417B14ECA62FC20E21AC3F82@DB9PR08MB7448.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <d43020611c65db3331d6ed534388ef5ca673553d.camel@siemens.com>
Hi,
>On Wed, 2026-07-15 at 09:04 +0000, Ulrich Teichert wrote:
>> Hi Felix,
>>
>> > > Add a check for "None" to raise a WicError because
>> > > get_bitbake_var may return "None" if the variable is not available, which
>> > > would result in an exception inside os.path.isdir and not to the WicError
>> > > exception as intended.
>>
>> > Hi,
>> >
>> > did you also send this patch to OE? Changes in the wic plugins that are
>> > not purely isar related have to be accepted by OE first (to avoid that
>> > our plugins diverge up to the point of not being able to update them
>> > anymore).
>>
>> No, I wasn't aware of the fact that the rootfs plugin comes from stock OE - but
>> in that case I'll divert my patch in that direction ;-)
Well, on OE-core this has been so completely overhauled (inheritance instead of
plugins, include-path hook does not even exist) that my patch doesn't make sense
there... Adopting it into Isar would not make matters worse, I'd say...
CU,
Uli
--
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/DB9PR08MB7448E417B14ECA62FC20E21AC3F82%40DB9PR08MB7448.eurprd08.prod.outlook.com.
prev parent reply other threads:[~2026-07-15 11:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-15 6:41 'Ulrich Teichert' via isar-users
2026-07-15 8:11 ` 'MOESSBAUER, Felix' via isar-users
2026-07-15 9:04 ` 'Ulrich Teichert' via isar-users
2026-07-15 9:26 ` 'MOESSBAUER, Felix' via isar-users
2026-07-15 9:55 ` Anton Mikanovich
2026-07-15 16:15 ` 'MOESSBAUER, Felix' via isar-users
2026-07-15 16:30 ` 'Jan Kiszka' via isar-users
2026-07-16 6:21 ` Anton Mikanovich
2026-07-15 11:33 ` 'Ulrich Teichert' via isar-users [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB9PR08MB7448E417B14ECA62FC20E21AC3F82@DB9PR08MB7448.eurprd08.prod.outlook.com \
--to=isar-users@googlegroups.com \
--cc=felix.moessbauer@siemens.com \
--cc=krypton@ulrich-teichert.org \
--cc=ulrich.teichert@ebs-group.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox