Re: [PATCH 3/3] rootfs: Deny packages download during install

["'Jan Kiszka' via isar-users" <isar-users@googlegroups.com>]

On 30.07.26 08:10, Moessbauer, Felix (FT RPD CED OES-DE) wrote:
> On Wed, 2026-07-29 at 21:39 +0200, Jan Kiszka wrote:
>> On 10.06.26 08:48, Anton Mikanovich wrote:
>>> During the command rootfs_install_pkgs_install no actuall packages
>>> downloading should be done. All the debs must be precached and already
>>> placed in /var/cache/apt/archives, so apt-get can reuse them.
>>>
>>> Currently any downloads in this command are really succeed because we
>>> still have "network" flag on for using sudo, which masks all the
>>> caching issues in previous rootfs install commands.
>>>
>>> To prevent such a cases add "--no-download" option to apt-get.
>>>
>>> Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
>>> ---
>>>  meta/classes-recipe/rootfs.bbclass | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/meta/classes-recipe/rootfs.bbclass b/meta/classes-recipe/rootfs.bbclass
>>> index 81384340..f4580421 100644
>>> --- a/meta/classes-recipe/rootfs.bbclass
>>> +++ b/meta/classes-recipe/rootfs.bbclass
>>> @@ -402,7 +402,7 @@ rootfs_install_pkgs_install[progress] = "custom:rootfs_progress.PkgsInstallProgr
>>>  rootfs_install_pkgs_install[network] = "${TASK_USE_SUDO}"
>>>  rootfs_install_pkgs_install() {
>>>      sudo -E chroot "${ROOTFSDIR}" \
>>> -        /usr/bin/apt-get ${ROOTFS_APT_ARGS} ${ROOTFS_PACKAGES}
>>> +        /usr/bin/apt-get ${ROOTFS_APT_ARGS} --no-download ${ROOTFS_PACKAGES}
>>>  }
>>>  
>>>  ROOTFS_INSTALL_COMMAND += "rootfs_restore_initrd_tooling"
>>
>> This commit subtly breaks xenomai-images when generating a compat 
>> userland:
>>
>> kas.yaml:kas/board/qemu-amd64.yaml:kas/opt/xenomai-3.3.x.yaml:kas/opt/linux-6.12.yaml:kas/opt/compat.yaml
>>
>> ...
>> | (Reading database ... 9732 files and directories currently installed.)
>> | Preparing to unpack .../systemd-sysv_252.39-1~deb12u2_amd64.deb ...
>> | Unpacking systemd-sysv (252.39-1~deb12u2) ...
>> | Setting up systemd-sysv (252.39-1~deb12u2) ...
>> | E: Internal Error, Pathname to install is not absolute 'libxenomai1_3.3.2_i386.deb'
>> | WARNING: exit code 100 from a shell command.
>> | DEBUG: Executing shell function rootfs_do_umounts
>> | DEBUG: Shell function rootfs_do_umounts finished
>> | DEBUG: Python function do_rootfs_install finished
>> ERROR: Task (/work/build/../../repo/recipes-core/images/demo-image.bb:do_rootfs_install) failed with exit code '1'
>> NOTE: Tasks Summary: Attempted 79 tasks of which 61 didn't need to be rerun and 1 failed.
>>
>> Target distro is trixie here. xenomai-images revision is 
>> 74664edd99cb44c830060207c4dcf5c9ff83c341 with isar set to 
>> b90b722fc2666b806a64f0bf5ca0feeb9b6f203b.
>>
>> Any idea where this could come from??
> 
> Isn't that exactly what Aliaksei fixes in "rootfs: Fix URL parsing"?
> In short, the error happens because the arch part is currently
> stripped.
> 
> [1] https://groups.google.com/g/isar-users/c/rQg0t7GyofM/m/oYZ7z2aEAwAJ
> 

Good hint to look there, but I rather suspect it's "rootfs: Add version
and arch for downloaded package"
(https://groups.google.com/g/isar-users/c/rQg0t7GyofM/m/LORd42aEAwAJ)

Let me try...

Jan

-- 
Siemens AG, Foundational Technologies
Linux Expert Center

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/92b21dd8-8d06-4732-9a9a-1cab84536a39%40siemens.com.