[PATCH] installer: only include wic.bmap for IMAGE_DATA_POSTFIX wic

[PATCH] installer: only include wic.bmap for IMAGE_DATA_POSTFIX wic

['Clara Kowalsky' via isar-users]

If a target image type other than wic is added to the installer's
rootfs, there is no corresponding wic.bmap file. Add the wic.bmap to the
rootfs only if the IMAGE_DATA_POSTFIX is wic.

Signed-off-by: Clara Kowalsky <clara.kowalsky@siemens.com>
---
 meta-isar/classes-recipe/installer-add-rootfs.bbclass | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/meta-isar/classes-recipe/installer-add-rootfs.bbclass b/meta-isar/classes-recipe/installer-add-rootfs.bbclass
index 111506df..c4921bc6 100644
--- a/meta-isar/classes-recipe/installer-add-rootfs.bbclass
+++ b/meta-isar/classes-recipe/installer-add-rootfs.bbclass
@@ -58,6 +58,7 @@ def get_mc_depends(d, task):
 
 python() {
     entries = []
+    image_data_postfix = d.getVar("IMAGE_DATA_POSTFIX") or ""
 
     def add_entries(postfix, suffix):
         sources = get_installer_sources(d, suffix)
@@ -70,8 +71,9 @@ python() {
             d.setVarFlag(var, "source", src)
             d.setVarFlag(var, "destination", dst)
 
-    add_entries("", d.getVar("IMAGE_DATA_POSTFIX"))
-    add_entries("-bmap", "wic.bmap")
+    add_entries("", image_data_postfix)
+    if image_data_postfix.startswith("wic"):
+        add_entries("-bmap", "wic.bmap")
 
     d.setVar("ROOTFS_ADDITIONAL_FILES", " ".join(entries))
 }
-- 
2.54.0

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/20260724091630.435595-1-clara.kowalsky%40siemens.com.

Re: [PATCH] installer: only include wic.bmap for IMAGE_DATA_POSTFIX wic

['Heinisch, Alexander' via isar-users]

On Fri, 2026-07-24 at 11:16 +0200, 'Clara Kowalsky' via isar-users
wrote:
> If a target image type other than wic is added to the installer's

Can you rephrase the commit message, so it's clear that wic.xz,
wic.zst, aso. remain valid options for bmap file copying?

> rootfs, there is no corresponding wic.bmap file. Add the wic.bmap to
> the
> rootfs only if the IMAGE_DATA_POSTFIX is wic.
> 
> Signed-off-by: Clara Kowalsky <clara.kowalsky@siemens.com>
> ---
>  meta-isar/classes-recipe/installer-add-rootfs.bbclass | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/meta-isar/classes-recipe/installer-add-rootfs.bbclass
> b/meta-isar/classes-recipe/installer-add-rootfs.bbclass
> index 111506df..c4921bc6 100644
> --- a/meta-isar/classes-recipe/installer-add-rootfs.bbclass
> +++ b/meta-isar/classes-recipe/installer-add-rootfs.bbclass
> @@ -58,6 +58,7 @@ def get_mc_depends(d, task):
>  
>  python() {
>      entries = []
> +    image_data_postfix = d.getVar("IMAGE_DATA_POSTFIX") or ""
>  
>      def add_entries(postfix, suffix):
>          sources = get_installer_sources(d, suffix)
> @@ -70,8 +71,9 @@ python() {
>              d.setVarFlag(var, "source", src)
>              d.setVarFlag(var, "destination", dst)
>  
> -    add_entries("", d.getVar("IMAGE_DATA_POSTFIX"))
> -    add_entries("-bmap", "wic.bmap")
> +    add_entries("", image_data_postfix)
> +    if image_data_postfix.startswith("wic"):
> +        add_entries("-bmap", "wic.bmap")
>  
>      d.setVar("ROOTFS_ADDITIONAL_FILES", " ".join(entries))
>  }
> -- 
> 2.54.0

-- 
Alexander Heinisch
Siemens AG
www.siemens.com

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/fadbe73b20f24e475e818f467235bc21be25caed.camel%40siemens.com.

Re: [PATCH] installer: only include wic.bmap for IMAGE_DATA_POSTFIX wic

['Clara Kowalsky' via isar-users]

On 7/27/26 15:57, Heinisch, Alexander (FT RPD CED SES-AT) wrote:
> On Fri, 2026-07-24 at 11:16 +0200, 'Clara Kowalsky' via isar-users
> wrote:
>> If a target image type other than wic is added to the installer's
> 
> Can you rephrase the commit message, so it's clear that wic.xz,
> wic.zst, aso. remain valid options for bmap file copying?

Done, sent v2. Thanks for pointing out.
BR,
Clara
> 
>> rootfs, there is no corresponding wic.bmap file. Add the wic.bmap to
>> the
>> rootfs only if the IMAGE_DATA_POSTFIX is wic.
>>
>> Signed-off-by: Clara Kowalsky <clara.kowalsky@siemens.com>
>> ---
>>   meta-isar/classes-recipe/installer-add-rootfs.bbclass | 6 ++++--
>>   1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta-isar/classes-recipe/installer-add-rootfs.bbclass
>> b/meta-isar/classes-recipe/installer-add-rootfs.bbclass
>> index 111506df..c4921bc6 100644
>> --- a/meta-isar/classes-recipe/installer-add-rootfs.bbclass
>> +++ b/meta-isar/classes-recipe/installer-add-rootfs.bbclass
>> @@ -58,6 +58,7 @@ def get_mc_depends(d, task):
>>   
>>   python() {
>>       entries = []
>> +    image_data_postfix = d.getVar("IMAGE_DATA_POSTFIX") or ""
>>   
>>       def add_entries(postfix, suffix):
>>           sources = get_installer_sources(d, suffix)
>> @@ -70,8 +71,9 @@ python() {
>>               d.setVarFlag(var, "source", src)
>>               d.setVarFlag(var, "destination", dst)
>>   
>> -    add_entries("", d.getVar("IMAGE_DATA_POSTFIX"))
>> -    add_entries("-bmap", "wic.bmap")
>> +    add_entries("", image_data_postfix)
>> +    if image_data_postfix.startswith("wic"):
>> +        add_entries("-bmap", "wic.bmap")
>>   
>>       d.setVar("ROOTFS_ADDITIONAL_FILES", " ".join(entries))
>>   }
>> -- 
>> 2.54.0
> 

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/933621e4-6ee7-4ab2-87c2-bf73459f0c2c%40siemens.com.